Date: Sat, 27 Apr 2013 18:05:40 +0200
From: Vladimir Marek <Vladimir.Marek@Oracle.COM>
To: Jani Nikula <jani@nikula.org>
Subject: Re: [PATCH] don't store temporary value returned from c_str()
Message-ID: <20130427160540.GB17459@vi64-x3-2e-prg06.cz.oracle.com>
References: <1366405933-17223-1-git-send-email-Vladimir.Marek@oracle.com>
	<878v44qhop.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <878v44qhop.fsf@nikula.org>
User-Agent: Mutt/ (2012-12-30)
Cc: notmuch@notmuchmail.org, Vladimir Marek <vlmarek@volny.cz>
Precedence: list

> It's okay to use the result of .c_str() as long as the string object
> stays in scope, and none of the non-const member functions are
> called. Here, I think the problem is that TermIterator's overloaded
> operator*() returns a string object within the if block's scope, and it
> goes immediately out of scope. You could check this by adding

Right, I overlooked that TermIterator creates temporary string (if I
understand you correctly).

> 
> 	string s = *i;
>
> in function scope, and replacing (*i) with s in the if block. This might
> also be more obvious than the presented patch, but I think the patch is
> fine too.

I would prefer my change as it avoids creating another std::string. At
least I think.

Thank you
-- 
	Vlad