From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Jed Brown <jed@59A2.org>,
	Jani Nikula <jani@nikula.org>, Karl Fogel <kfogel@red-bean.com>,
	Daniel Bergey <bergey@alum.mit.edu>
Subject: Re: [PATCH] emacs: add missing paren to fix defun in
	notmuch-address.el.
In-Reply-To: <87vc7vgbym.fsf@zancas.localnet>
References: <87wqsfik5l.fsf@floss.red-bean.com>
	<87mwtah2hd.fsf@zancas.localnet>
	<877gkeau42.fsf@floss.red-bean.com>
	<m2ppy5v3mc.fsf@guru.guru-group.fi> <8738v1jtzc.fsf@nikula.org>
	<87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov>
	<m2hajgxli5.fsf@guru.guru-group.fi>
	<87vc7vgbym.fsf@zancas.localnet>
User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Tue, 09 Apr 2013 15:12:34 +0300
Message-ID: <m2ehejykb1.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Cc: notmuch@notmuchmail.org
Precedence: list

On Tue, Apr 09 2013, David Bremner wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> On Tue, Apr 09 2013, Jed Brown wrote:
>>
>>> David Bremner <david@tethera.net> writes:
>>>
>>>> Squashed sounds good to me too. Sorry I'm too lazy/busy at the moment to
>>>> do it myself.
>>>
>>> I tested the attached and it's working as expected.  Sent as an
>>> attachment to preserve author information.
>>
>> LGTM (this time tested, too). Also compared diffs by hand, change as announced.
>> comments in id:m26207wgyt.fsf@guru.guru-group.fi (amend!) apply. 
>
> There seems to be a few warnings:
>
> In notmuch-bbdb/snarf-from:
> notmuch-address.el:116:26:Warning: reference to free variable
>     `bbdb-get-addresses-headers'
>
> In notmuch-bbdb/snarf-to:
> notmuch-address.el:122:29:Warning: reference to free variable
>     `bbdb-get-addresses-headers'
>
> In end of data:
> notmuch-address.el:143:1:Warning: the following functions are not known to be
>     defined: bbdb-get-addresses, bbdb-update-records, notmuch-show-get-header
>
> Do we need a few defvars?

For the above set, something like:

(defvar bbdb-get-addresses-headers)

(declare-function notmuch-show-get-header "notmuch-show" (header &optional props))

(declare-function bbdb-get-addresses "bbdb-com" 
  (only-first-address
   uninteresting-senders
   get-header-content-function
   &rest get-header-content-function-args))

(declare-function bbdb-update-records "bbdb-com" (addrs auto-create-p offer-to-create))

> d

Tomi