From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [Patch v4 1/3] doc: build and install doxygen api docs
In-Reply-To: <1404863829-3343-2-git-send-email-david@tethera.net>
References: <1404657994-30628-4-git-send-email-david@tethera.net>
	<1404863829-3343-1-git-send-email-david@tethera.net>
	<1404863829-3343-2-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.18.1+25~gdaf4b6f (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 09 Jul 2014 23:22:49 +0300
Message-ID: <m21ttuqo2u.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Wed, Jul 09 2014, David Bremner <david@tethera.net> wrote:

> In order to support out of tree builds, generate `doc/config.dox` from
> configure.
>
> In order to avoid hardcoding version in doxygen.cfg, generate
> doc/version.dox at build time.

is this commit message accurate ?

> ---
>  configure          | 12 ++++++++++++
>  doc/Makefile.local | 27 +++++++++++++++++++++++++--
>  doc/doxygen.cfg    |  5 ++---
>  3 files changed, 39 insertions(+), 5 deletions(-)
>
> diff --git a/configure b/configure
> index 9514d4d..fa44188 100755
> --- a/configure
> +++ b/configure
> @@ -417,6 +417,15 @@ else
>      have_emacs=0
>  fi
>  
> +printf "Checking if doxygen is available... "
> +if doxygen -v > /dev/null 2>&1; then

Doxygen 1.6.1 does not know -v -- and exits w/ value 1. If we wanted to
allow man generation using that version (out-of-the-box) then the line
above should be `if command -v doxygen >/dev/null; then`

otherwise this series looks good and generation seems to work.

Tomi

> +    printf "Yes.\n"
> +    have_doxygen=1
> +else
> +    printf "No (so will not install api docs)\n"
> +    have_doxygen=0
> +fi
> +