From: Florian Friesdorf <flo@chaoflow.net>
To: Chris Gray <chrismgray@gmail.com>, David Edmondson <dme@dme.org>,
	notmuch@notmuchmail.org
Subject: Re: [RFC][PATCH] emacs: Provide scaffolding so that the new `shr'
	HTML renderer can run.
In-Reply-To: <8762hbkas3.fsf@gmail.com>
References: <1324309559-7993-1-git-send-email-dme@dme.org>
	<8762hbkas3.fsf@gmail.com>
User-Agent: Notmuch/0.11 (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-unknown-linux-gnu)
Date: Mon, 23 Jan 2012 15:43:08 +0100
Message-ID: <8762g2qy2r.fsf@eve.chaoflow.net>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Mon, 19 Dec 2011 23:38:36 -0700, Chris Gray <chrismgray@gmail.com> wrote:
> > +;; Nonsense required to have the new gnus `shr' HTML display code
> > +;; work.
> > +(defvar gnus-summary-buffer)
> > +(defvar gnus-inhibit-images)
> 
> I believe that gnus-inhibit-images is defined in gnus-art.el.  Perhaps
> that file should just be require'd rather than having this workaround.

With notmuch-0.11 (require 'gnus-art') "fixes" the void
gnus-inhibit-images error.

> > +(if (not (fboundp 'gnus-blocked-images))
> > +    (defun gnus-blocked-images () nil))
> > +
> >  (defun notmuch-show-mm-display-part-inline (msg part nth content-type)
> >    "Use the mm-decode/mm-view functions to display a part in the
> >  current buffer, if possible."
> > @@ -331,7 +338,12 @@ current buffer, if possible."
> >  	    (let ((content (notmuch-show-get-bodypart-content msg part nth)))
> >  	      (insert content)
> >  	      (set-buffer display-buffer)
> > -	      (mm-display-part handle)
> > +
> > +	      ;; Nonsense required to have the new gnus `shr' HTML
> > +	      ;; display code work.
> > +	      (let ((gnus-inhibit-images nil))
> > +		(makunbound 'gnus-summary-buffer) ; Blech.
> 
> This is working around a bug in gnus.  I think the better solution would
> be for gnus to fix the bug.  The following patch against gnus works for
> me.  (I have tried submitting it to the gnus bug list, but have not been
> able to check if it got through.)

emacs git master has a fix for that, so you seem to have got through.

-- 
Florian Friesdorf <flo@chaoflow.net>
  GPG FPR: 7A13 5EEE 1421 9FC2 108D  BAAF 38F8 99A3 0C45 F083
Jabber/XMPP: flo@chaoflow.net
IRC: chaoflow on freenode,ircnet,blafasel,OFTC