From: Jani Nikula <jani@nikula.org>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/1] devel/STYLE: information how to enable standard
	pre-commit hook
In-Reply-To: <1364040435-22357-1-git-send-email-tomi.ollila@iki.fi>
References: <1364040435-22357-1-git-send-email-tomi.ollila@iki.fi>
User-Agent: Notmuch/0.15.2+34~ga90fdd9 (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Tue, 26 Mar 2013 10:18:11 +0100
Message-ID: <87ppymfrjg.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: tomi.ollila@iki.fi
Precedence: list

On Sat, 23 Mar 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> It is easier to enable git standard pre-commit hook, when the
> operation to do so is presented.
> ---
>  devel/STYLE | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/devel/STYLE b/devel/STYLE
> index 0792ba1..92de42c 100644
> --- a/devel/STYLE
> +++ b/devel/STYLE
> @@ -45,8 +45,9 @@ function (param_type param, param_type param)
>     - likewise, there is a space following keywords such as if and while
>     - every binary operator should have space on either side.
>  
> -* No trailing whitespace. Please enable the standard pre-commit hook
> -  in git (or an equivalent hook).
> +* No trailing whitespace. Please enable the standard pre-commit hook in git
> +  (or an equivalent hook). The standard pre-commit hook is enabled by simply
> +  renaming file '.git/hooks/pre-commit.sample' to '.git/hooks/pre-commit' .

<bikeshedding>

Or just refer to http://git-scm.com/book/en/Customizing-Git-Git-Hooks or
man githooks if you really need to. Older versions of git used to have
properly named hooks with the executable bit unset...

Personally I wouldn't ask anyone to enable the hook because I wouldn't
enable it in the first place. There's $EDITOR and 'git diff --check' to
do that kind of thing... When I want to commit I want to commit, warts
and all, and I don't want a hook to prevent me from doing so!

</bikeshedding>

BR,
Jani.