From: Michal Nazarewicz <mpn@google.com>
To: Austin Clements <amdragon@MIT.EDU>
Subject: Re: [PATCH] emacs: notmuch-search: fix faces
In-Reply-To: <20120828002215.GB11179@mit.edu>
Organization: Google Inc
References:
 <83882f4c8de5317e0184dc091a197b2341e5f015.1345725028.git.mina86@mina86.com>
	<87ipc4jcfv.fsf@servo.finestructure.net>	<xa1t3938ue0m.fsf@mina86.com>
 <20120828002215.GB11179@mit.edu>
User-Agent: Notmuch/0.14+2~g416b120 (http://notmuchmail.org) Emacs/24.2.50.1
	(x86_64-unknown-linux-gnu)
Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC
Date: Tue, 28 Aug 2012 02:51:49 +0200
Message-ID: <xa1twr0ju9cq.fsf@mina86.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

> Quoth Michal Nazarewicz on Aug 28 at  1:11 am:
>> I'm not an expert either, but with this patch applied I see colours,
>> without this patch, I don't see colours, ie. everything is rendered
>> using the default face.
>>=20
>> I'm also not entirely sure if that's the correct way of doing things
>> since 'face seems to be working in other modes (most notably
>> notmuch-show).  By posting, I'm also hoping that someone more
>> experienced will maybe take a look to see what's going on here... ;)
>>=20
>> For some more info, in notmuch-show mode, I get-text-property of nil for
>> both 'face and 'font-lock-face, but in message-mode or in *scratch*
>> buffer I'm getting nil for 'font-lock-face but non-nil for 'face.  With
>> the patch, I'm getting the same non-nil for both 'face and
>> 'font-lock-face; without the patch, I'm getting nil for both.

Austin Clements <amdragon@MIT.EDU> writes:
> This is odd.  Could you give more details about your environment?  In
> particular, what Emacs version are you running and might you have any
> unusual Emacs packages installed or customizations set?

I'm running Emacs compiled from a week old bzr head, emacs-version
reports: =E2=80=9CGNU Emacs 24.2.50.1 (x86_64-unknown-linux-gnu) of 2012-08=
-21
on mpn-glaptop=E2=80=9D.

I don't think I have any =E2=80=9Cunusual=E2=80=9D packages, but I do have =
quite a bit
of customization, which you might find at
<https://github.com/mina86/dot-files/blob/master/dot-emacs>.

> The unusual thing about font-lock-face is that it only gets applied if
> font-lock is enabled; otherwise it's ignored.  One theory is that the
> nil font-lock-face (without your patch) is causing font-lock to
> *override* the face property that we set.  I don't think font-lock
> usually does that, but perhaps in some situations, it will?

Ha!  That could be the cause.  I've disabled global-font-lock-mode, and
the colours appeared.  Getting property returns non-nil for 'face and
nil for 'font-lock-face.  When I enable font-lock-mode the property seem
to disappear and disabling font-lock-mode again does not help.

--=20
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=3D./ `o
..o | Computer Science,  Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz   =
 (o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
--=-=-=
Content-Type: multipart/signed; boundary="==-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"

--==-=-=
Content-Type: text/plain


--==-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQIcBAEBAgAGBQJQPBYlAAoJECBgQBJQdR/0EJ0P/38g1ch0y6r7rKRZwXS3r+9a
T0JEQorWG7BLW7M3HIc+0WWWkX1hMBVcELcRwnTP1UfZjd/eBlPfpjlaID5Ridpd
dMcWQuiSO+w6gJ2CBxOhu+c68uyh2N9aiJQkymEZ1/tRTdkq5mS26QWUaiR9KFpe
aKXnXLhYKzttDwQrEv+YL9pbPm3Onu+SJfLpUMmyU2Sx9j/0TmXkT4YajAuWqnlW
xQUNdNHT9/uMCWNhHpDUnp9TkCoN+txT8P42GPEYN7oLBq+UF8RpRELLGvBmMUa2
PMmJlBrNQ7hZzubSs365nxRn9AZ7AwdTibygCkxqLGXGOb7csebSQrlIxELwySIR
oqrEM2VBX8rNWiNFKK3I4xSoiwEwh2qBOJzK/nD9I7/FeEDzfuwPJYG70f2Qg/YY
KALuplvmjp9i8tu4N/70x5wuxI3SLgtwJFLkn4EBB6uYXAzRWdOEqintLaXB4/JT
cqNIrVmxnlldKiKXsEIhZSuoDK1IlxIXjliBItRE3WFKNB726YIVN/W3VADpbQfQ
87abX7Xb9a/HwbgQXetc8XQPpWJHCSCaa8aQsbPNSbb5PJXqD2OyUUBdzsOPEqC6
xmHHTb+fDfSyxs7CmQGGQN4cUkEPElzSBv6U/xmKpVbgmpNo+huhDSSw18ABBYGK
a/QlQXI25Gpxvdre5Z8u
=oFrd
-----END PGP SIGNATURE-----
--==-=-=--

--=-=-=--