Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 7B2B7431FDB for ; Sat, 19 Jan 2013 16:51:48 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DOnICxx3CAeQ for ; Sat, 19 Jan 2013 16:51:48 -0800 (PST) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 84924429E41 for ; Sat, 19 Jan 2013 16:51:37 -0800 (PST) Received: by mail-pb0-f50.google.com with SMTP id wz7so2689974pbc.9 for ; Sat, 19 Jan 2013 16:51:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=8ya8FZd2NothubvelH0oCk8DDpSG2jg9ICl+hjH0GsE=; b=0/4th3sjYnJyqhDlYdPvnPhygeHaS/tylo0C+wpVYXv/KFty8EcJ0pK9PcAV20ZUq9 NhcpbIGbBQkwtKoUh8UFZswl514SB5Twcvqzm2NU6U8CK1NDHtTz4Yz3XbRZKDzqIO5H IbK0A6+l8oKZiS9qNW1aRoyEnD/NsKtiIXIcLbwwnno0YQe6AOnFUVyxHosZwmTvAlvA J8wewQ5xhqR2eLlON471D4KRiB4LxzhyJaTSTXRNee+X8DR4OoXCw5BDvkoelii98tFs 0ayPkRmXqysktcefC6TfgD4se/KLORe/AKRIWk7X8Ltnnygqq135pXgXz/8Hk4TpAxpp OiwA== X-Received: by 10.69.1.73 with SMTP id be9mr18849166pbd.116.1358643096695; Sat, 19 Jan 2013 16:51:36 -0800 (PST) Received: from localhost (215.42.233.220.static.exetel.com.au. [220.233.42.215]) by mx.google.com with ESMTPS id i5sm6271689pax.13.2013.01.19.16.51.34 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 19 Jan 2013 16:51:36 -0800 (PST) From: Peter Wang To: notmuch@notmuchmail.org Subject: [PATCH v3 13/20] insert: fsync after writing tmp file Date: Sun, 20 Jan 2013 11:49:57 +1100 Message-Id: <1358643004-14522-14-git-send-email-novalazy@gmail.com> X-Mailer: git-send-email 1.7.12.1 In-Reply-To: <1358643004-14522-1-git-send-email-novalazy@gmail.com> References: <1358643004-14522-1-git-send-email-novalazy@gmail.com> X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jan 2013 00:51:50 -0000 Flush the tmp file to disk after writing for durability. --- notmuch-insert.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/notmuch-insert.c b/notmuch-insert.c index 85acaea..60855c1 100644 --- a/notmuch-insert.c +++ b/notmuch-insert.c @@ -305,6 +305,10 @@ insert_message (void *ctx, notmuch_database_t *notmuch, int fdin, return FALSE; } ret = copy_stdin (fdin, fdout); + if (ret && fsync (fdout) != 0) { + fprintf (stderr, "Error: fsync failed: %s\n", strerror (errno)); + ret = FALSE; + } close (fdout); if (ret) { ret = maildir_move_tmp_to_new (tmppath, newpath); -- 1.7.12.1