MIME-Version: 1.0
Sender: awg@xvx.ca
In-Reply-To: <1334077496-9172-2-git-send-email-markwalters1009@gmail.com>
References: <1334077496-9172-1-git-send-email-markwalters1009@gmail.com>
	<1334077496-9172-2-git-send-email-markwalters1009@gmail.com>
Date: Tue, 10 Apr 2012 11:19:07 -0600
Message-ID:
 <CAMoJFUuXmLQR+awJnPKg8ZJAKbHbPAmSrEUVoFj_=dZ76WiKzw@mail.gmail.com>
Subject: Re: [PATCH 1/2] cli: make --entire-thread=false work for format=json.
From: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
To: Mark Walters <markwalters1009@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: notmuch@notmuchmail.org
Precedence: list

Hi Mark,

This looks good to me, but I haven't tested it. It's probably worth
adding a test for the new functionality.

One style issue below, which is a matter of taste and I'll defer to
others if they disagree:

On Tue, Apr 10, 2012 at 11:04, Mark Walters <markwalters1009@gmail.com> wro=
te:
> @@ -895,10 +905,11 @@ show_messages (void *ctx,
> =A0 =A0 =A0 =A0 =A0 =A0if (status && !res)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0res =3D status;
> =A0 =A0 =A0 =A0 =A0 =A0next_indent =3D indent + 1;
> + =A0 =A0 =A0 } else
> + =A0 =A0 =A0 =A0 =A0 status =3D show_null_message (format);

I accept, but don't particularly like, the notmuch style of omitting
braces where they aren't required. However, an else with a brace on
only one side just looks weird. If they're like this everywhere else
then I guess it's best to be consistent, but to me it's a lot more
readable as } else {.

As I said above, I'll defer to others' judgement here, just thought it
was worth pointing out.

-- Adam