To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 5/5] emacs: Retain the state of the buffer during
	`notmuch-show-refresh-view'.
In-Reply-To: <87k449vt84.fsf@qmul.ac.uk>
References: <1327486729-18052-1-git-send-email-dme@dme.org>
	<1327941064-20027-1-git-send-email-dme@dme.org>
	<1327941064-20027-6-git-send-email-dme@dme.org>
	<87k449vt84.fsf@qmul.ac.uk>
User-Agent: Notmuch/0.11+133~gdd93bad (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Tue, 31 Jan 2012 06:17:58 +0000
Message-ID: <cunbopkjsyx.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Mon, 30 Jan 2012 20:19:23 +0000, Mark Walters <markwalters1009@gmail.com=
> wrote:
> The first is that I currently sometimes use =3D (that is
> notmuch-show-refresh-view) as a way to go back to the original state (ie
> which messages are open and back to the first message) so I am not sure
> the keep state version should completely replace the old one. (Maybe
> there is an alternative way to achieve the same effect that I don't
> know!)

Thinking about it afterwards, I agree. That is:
    - '=3D' should behave as though the buffer was remade anew,
    - the toggle commands should retain the state.

> Secondly in
>=20
> >  (defun notmuch-show-refresh-view ()
> >    "Refresh the current view.
> >=20=20
> >  Refreshes the current view, observing changes in cryptographic prefere=
nces."
> >    (interactive)
> > -  (let ((inhibit-read-only t))
> > -    (erase-buffer))
> > -  (notmuch-show-worker notmuch-show-thread-id notmuch-show-parent-buff=
er
> > -		       notmuch-show-query-context))
> > +  (let ((inhibit-read-only t)
> > +	(state (notmuch-show-capture-state)))
> > +    (erase-buffer)
> > +    (notmuch-show-worker notmuch-show-thread-id notmuch-show-parent-bu=
ffer
> > +			 notmuch-show-query-context)
> > +    (notmuch-show-apply-state state)))
>=20
> how would you feel about a (notmuch-show-message-adjust) at the end?

Agreed.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8nh5YACgkQaezQq/BJZRbqYQCeK1+8GwopR8+aueOjazMnlS0R
RrAAnRRrD4GGZXJyyYW4ZVDOsvkztTsU
=uhk7
-----END PGP SIGNATURE-----
--=-=-=--