To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 3/3] search: Support automatic tag exclusions
In-Reply-To: <87wr8tsvit.fsf@servo.finestructure.net>
References: <1326258173-21163-1-git-send-email-amdragon@mit.edu>
	<1326496024-14403-1-git-send-email-amdragon@mit.edu>
	<1326496024-14403-4-git-send-email-amdragon@mit.edu>
	<87wr8tsvit.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.10.2+186~gd0f7804 (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Mon, 16 Jan 2012 09:12:38 +0000
Message-ID: <cunfwfg57uh.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Sat, 14 Jan 2012 15:40:26 -0800, Jameson Graef Rollins <jrollins@finestr=
ucture.net> wrote:
> This patch looks fine.  Philosophical UI discussion to follow:
>=20
> On Fri, 13 Jan 2012 18:07:04 -0500, Austin Clements <amdragon@MIT.EDU> wr=
ote:
> > +    if (notmuch_config_get_auto_exclude_tags (config, &tmp) =3D=3D NUL=
L) {
> > +	const char *tags[] =3D { "deleted", "spam" };
> > +	notmuch_config_set_auto_exclude_tags (config, tags, 2);
> > +    }
>=20
> This creates the config section with the exclude list pre-set to
> "deleted;spam".

I don't think that anything should be excluded from the search results
by default, at least not as a default behaviour of the 'notmuch'
binary.

Having "deleted" and "spam" as default settings in the configuration
file might be more reasonable.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8T6gYACgkQaezQq/BJZRZ0EQCcC/YqvlEOonCwA8D/oHjy2he5
GmAAn2oNgiUBUSpVwHXJ9uVpXUXLFHYW
=CgtL
-----END PGP SIGNATURE-----
--=-=-=--