Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 6EF76431FB6 for ; Sun, 13 Jan 2013 06:37:52 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3cGhGhGt8a2X for ; Sun, 13 Jan 2013 06:37:50 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 57CDE431FAF for ; Sun, 13 Jan 2013 06:37:50 -0800 (PST) Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.82.78] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1TuOgy-00066M-QO; Sun, 13 Jan 2013 10:37:49 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TuOgt-0007G8-5r; Sun, 13 Jan 2013 10:37:39 -0400 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 1/1] cli: propagate batch tagging warnings to exit value In-Reply-To: <1357976414-7468-1-git-send-email-tomi.ollila@iki.fi> References: <1357976414-7468-1-git-send-email-tomi.ollila@iki.fi> User-Agent: Notmuch/0.14+257~ge43e0af (http://notmuchmail.org) Emacs/24.2.1 (x86_64-pc-linux-gnu) Date: Sun, 13 Jan 2013 10:37:39 -0400 Message-ID: <87fw25cfnw.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - Cc: tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Jan 2013 14:37:52 -0000 Tomi Ollila writes: > In case last input for batch tagging was either invalid or skippable > line, notmuch command exited with non-zero value. > After this change if there is at least one invalid line, notmuch > command will exit with non-zero value. Additionally, skipped lines > (last or other) doesn't cause non-zero value to be returned. This looks OK. In a perfect world we'd have a test for return values. d