From: Mark Walters <markwalters1009@gmail.com>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Istvan Marko <notmuch@kismala.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts
In-Reply-To: <87fvu4fl25.fsf@servo.finestructure.net>
References: <m3r4dtgz9k.fsf@zsu.kismala.com>
	<87fvu4fl25.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.15.2+192~g8222af3 (http://notmuchmail.org) Emacs/23.4.1
	(i486-pc-linux-gnu)
Date: Tue, 20 Aug 2013 19:23:24 +0100
Message-ID: <87ob8ste5f.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


Hi

What does the (mis-behaving)  part button say? is it [image/jpeg] or
[application/octet-stream as image/jpeg] or? and what do correctly
behaving part buttons say?

Best wishes

Mark

Jameson Graef Rollins <jrollins@finestructure.net> writes:

> On Fri, Aug 16 2013, Istvan Marko <notmuch@kismala.com> wrote:
>> When text/html parts include images as multipart/related and the
>> text/plain alternative is used these images can be completely hidden
>> with no easy way to access them or even find out that they are there.
>>
>> Make notmuch-show-insert-part-multipart/related add buttons for all
>> parts, the first one visible the rest hidden.
>
> Hey, Istvan.  Thanks so much for this patch.  It seems to be addressing
> the same issue I reported in id:87ob8u8l6k.fsf@servo.finestructure.net.
>
> However, the behavior of the part button that now appears seems to be a
> bit strange.  Clicking/hitting enter on the part attempts to save it
> rather than open it.  I wouldn't be surprised if has nothing to do with
> the correctness of this patch, though.  So is it possible that the
> button is not inserted in the most ideal way, or is there some other
> issue preventing it from behaving properly (could it have to do with the
> part being "inline"?)?
>
> jamie.
>
>
>>  emacs/notmuch-show.el | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
>> index 82b70ba..20844f0 100644
>> --- a/emacs/notmuch-show.el
>> +++ b/emacs/notmuch-show.el
>> @@ -621,6 +621,10 @@ message at DEPTH in the current thread."
>>  
>>      ;; Render the primary part.
>>      (notmuch-show-insert-bodypart msg (car inner-parts) depth)
>> +    ;; Add hidden buttons for the rest
>> +    (mapc (lambda (inner-part)
>> +	    (notmuch-show-insert-bodypart msg inner-part depth t))
>> +	  (cdr inner-parts))
>>  
>>      (when notmuch-show-indent-multipart
>>        (indent-rigidly start (point) 1)))
>> -- 
>> 1.8.1.4
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch