From: Carl Worth <cworth@cworth.org>
To: Bart Trojanowski <bart@jukie.net>, notmuch@notmuchmail.org
In-Reply-To: <1259376580-934-1-git-send-email-bart@jukie.net>
References: <20091128022115.662B62053465E@oxygen.jukie.net>
	<1259376580-934-1-git-send-email-bart@jukie.net>
Date: Wed, 02 Dec 2009 16:19:28 -0800
Message-ID: <87zl60di3z.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: Bart Trojanowski <bart@jukie.net>
Subject: Re: [notmuch] [PATCH 1/2] notmuch-show: limit display to only
 matching messages
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Fri, 27 Nov 2009 21:49:39 -0500, Bart Trojanowski <bart@jukie.net> wrote:
> This patch changes the default behaviour of notmuch show to display only
> messages that match the search expression.  However, --entire-thread
> option is provided to display all messages in threads that matched the
> search expression.
>=20
> It is deemed that will be more useful for human users on the command line.
> Scripts can be modified to include the --entire-thread option so that they
> can display all messages once more.

Thanks Bart.

I've now applied this as well as your following patch to make vim call
"notmuch show" with the --entire-thread option. I also added support to
the emacs client to do the same, and I updated the notmuch man page to
document the option.

Finally, I noticed that not passing the --entire-thread option caused
"notmuch show" to lose all nesting and thread-ordering characteristics,
(even if display the entire thread incidentally). This came from calling
notmuch_query_search_messages (which doesn't do any threading) rather
than notmuch_query_search_threads. So I committed the patch below which
causes it to once again call search_threads and simply not display any
messages that don't match the search when called without
=2D-entire-thread.

I'll be glad if you have any comments to share.

=2DCarl

commit e1cb6126cc7f66cf71df8880c798f4d0f9d2e411
Author: Carl Worth <cworth@cworth.org>
Date:   Wed Dec 2 16:05:23 2009 -0800

    notmuch show: Preserve thread-ordering and nesting without --entire-thr=
ead
=20=20=20=20
    When "notmuch show" was recently modified to not show an entire thread
    by default, it also lost all capability to properly order the messages
    in a thread and to print their proper depth. For example, the command:
=20=20=20=20
    	notmuch show thread:6d5e3e276461188c5778c9f219f63782
=20=20=20=20
    had dramatically different output than:
=20=20=20=20
    	notmuch show --entire-thread thread:6d5e3e276461188c5778c9f219f63782
=20=20=20=20
    even though both commands were selecting and displaying the same set
    of messages. The first command would diplay them "flat", (all with
    depth:0), and in strict date order; while the second command would
    display them "nested" (with depth based on threading), and in thread
    order.
=20=20=20=20
    We now fix "notmuch show" without the --entire-thread option to also
    display nested and thread-ordered messages.
=20=20=20=20
    If some messages in the thread are not included in the displayed
    results, then they are not counted when computing depth values.

diff --git a/notmuch-show.c b/notmuch-show.c
index 60339d0..376aacd 100644
=2D-- a/notmuch-show.c
+++ b/notmuch-show.c
@@ -184,9 +184,12 @@ show_message (void *ctx, notmuch_message_t *message, i=
nt indent)
=20
=20
 static void
=2Dshow_messages (void *ctx, notmuch_messages_t *messages, int indent)
+show_messages (void *ctx, notmuch_messages_t *messages, int indent,
+	       notmuch_bool_t entire_thread)
 {
     notmuch_message_t *message;
+    notmuch_bool_t match;
+    int next_indent;
=20
     for (;
 	 notmuch_messages_has_more (messages);
@@ -194,9 +197,17 @@ show_messages (void *ctx, notmuch_messages_t *messages=
, int indent)
     {
 	message =3D notmuch_messages_get (messages);
=20
=2D	show_message (ctx, message, indent);
+	match =3D notmuch_message_get_flag (message, NOTMUCH_MESSAGE_FLAG_MATCH);
=20
=2D	show_messages (ctx, notmuch_message_get_replies (message), indent + 1);
+	next_indent =3D indent;
+
+	if (match || entire_thread) {
+	    show_message (ctx, message, indent);
+	    next_indent =3D indent + 1;
+	}
+
+	show_messages (ctx, notmuch_message_get_replies (message),
+		       next_indent, entire_thread);
=20
 	notmuch_message_destroy (message);
     }
@@ -257,29 +268,21 @@ notmuch_show_command (void *ctx, unused (int argc), u=
nused (char *argv[]))
 	return 1;
     }
=20
=2D    if (!entire_thread) {
=2D	messages =3D notmuch_query_search_messages (query);
=2D	if (messages =3D=3D NULL)
=2D	    INTERNAL_ERROR ("No messages.\n");
=2D	show_messages (ctx, messages, 0);
=2D
=2D    } else {
=2D	for (threads =3D notmuch_query_search_threads (query);
=2D		notmuch_threads_has_more (threads);
=2D		notmuch_threads_advance (threads))
=2D	{
=2D	    thread =3D notmuch_threads_get (threads);
+    for (threads =3D notmuch_query_search_threads (query);
+	 notmuch_threads_has_more (threads);
+	 notmuch_threads_advance (threads))
+    {
+	thread =3D notmuch_threads_get (threads);
=20
=2D	    messages =3D notmuch_thread_get_toplevel_messages (thread);
+	messages =3D notmuch_thread_get_toplevel_messages (thread);
=20
=2D	    if (messages =3D=3D NULL)
=2D		INTERNAL_ERROR ("Thread %s has no toplevel messages.\n",
=2D			notmuch_thread_get_thread_id (thread));
+	if (messages =3D=3D NULL)
+	    INTERNAL_ERROR ("Thread %s has no toplevel messages.\n",
+			    notmuch_thread_get_thread_id (thread));
=20
=2D	    show_messages (ctx, messages, 0);
+	show_messages (ctx, messages, 0, entire_thread);
=20
=2D	    notmuch_thread_destroy (thread);
=2D	}
+	notmuch_thread_destroy (thread);
     }
=20
     notmuch_query_destroy (query);

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLFwQQ6JDdNq8qSWgRAn3MAJ9ZyR/ZdcLdUpMq76Rb8WPhTwQdiQCfWMyX
VytwnnIMZzBwwuUSa3xw1SQ=
=W8ne
-----END PGP SIGNATURE-----
--=-=-=--