Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C3060429E25 for ; Sat, 12 Nov 2011 09:49:34 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7dAe14iPuIWd for ; Sat, 12 Nov 2011 09:49:34 -0800 (PST) Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id DC893431FB6 for ; Sat, 12 Nov 2011 09:49:33 -0800 (PST) Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31]) by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id pACHnTrX027443; Sat, 12 Nov 2011 19:49:29 +0200 From: Tomi Ollila To: David Bremner , Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH] test: do not hide test_emacs errors In-Reply-To: <87mxc1mlqm.fsf@rocinante.cs.unb.ca> References: <1309487028-18786-1-git-send-email-dmitry.kurochkin@gmail.com> <87mxc1mlqm.fsf@rocinante.cs.unb.ca> User-Agent: Notmuch/0.9+23~g556c5fa (http://notmuchmail.org) Emacs/23.3.1 (i686-pc-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Nov 2011 17:49:34 -0000 On Sat, 12 Nov 2011 09:57:53 -0500, David Bremner wrote: > On Fri, 1 Jul 2011 06:23:48 +0400, Dmitry Kurochkin wrote: > > Do not redirect test_emacs stderr to /dev/null. Test_emacs uses > > emacsclient(1) now and it does not print unwanted messages (like > > those from `message') to stderr. But it does print useful > > errors, e.g. when emacs server connection fails, given expression > > is not valid or undefined function is called. > > Is this patch still relevant now that we use dtach to run the tests? I think this is. running test_emacs may output useful information in cases test fails (or when initially failing to launc emacs server). Normally it doesn't seem to output anything -- and therefore the redirections to /dev/null are not needed. > I didn't notice any difference, but maybe I was not supposed to. Me neither. > > d Tomi