Return-Path: <michael.hudson@canonical.com>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 5089F431FD0
	for <notmuch@notmuchmail.org>; Wed, 24 Aug 2011 03:46:22 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 0JWbob7hpItE for <notmuch@notmuchmail.org>;
	Wed, 24 Aug 2011 03:46:21 -0700 (PDT)
Received: from youngberry.canonical.com (youngberry.canonical.com
	[91.189.89.112])
	by olra.theworths.org (Postfix) with ESMTP id A1E9C431FB6
	for <notmuch@notmuchmail.org>; Wed, 24 Aug 2011 03:46:21 -0700 (PDT)
Received: from 121-73-77-183.cable.telstraclear.net ([121.73.77.183]
	helo=angrist) by youngberry.canonical.com with esmtpsa
	(TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71)
	(envelope-from <michael.hudson@canonical.com>)
	id 1QwAyR-0002gY-5b; Wed, 24 Aug 2011 10:46:19 +0000
Received: by angrist (Postfix, from userid 1000)
	id 7B5C32033CE; Wed, 24 Aug 2011 22:46:15 +1200 (NZST)
From: Michael Hudson-Doyle <michael.hudson@canonical.com>
To: Sebastian Spaeth <Sebastian@SSpaeth.de>, notmuch@notmuchmail.org,
	David Bremner <david@tethera.net>
Subject: Re: [PATCH] Do not import notmuch in setup.py (again).
In-Reply-To: <87zkizxoks.fsf@SSpaeth.de>
References: <87d3fvvdqp.fsf@canonical.com> <87zkizxoks.fsf@SSpaeth.de>
User-Agent: Notmuch/0.7 (http://notmuchmail.org) Emacs/23.1.50.1
	(x86_64-pc-linux-gnu)
Date: Wed, 24 Aug 2011 22:46:15 +1200
Message-ID: <87ty971408.fsf@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Aug 2011 10:46:22 -0000

rOn Wed, 24 Aug 2011 09:20:51 +0200, Sebastian Spaeth <Sebastian@SSpaeth.de> wrote:
> On Wed, 24 Aug 2011 12:45:34 +1200, Michael Hudson-Doyle <michael.hudson@canonical.com> wrote:
> > Revert part of 8826f.  As explained in c39b492c, importing notmuch in setup.py breaks make -f debian/rules clean in an environment that does not have notmuch installed already.
> 
> Ahh, sorry, I must have missed that patch (or forgotten about it). I
> solved this now by having the version number in version.py (which
> contains nothing else, so David Bremner can easily overwrite it with
> makefile magic :-)).

Ah cool.

> @David, feel free to automagically modify (or overwrite)
> bindings/python/notmuch/version.py.
> 
> We read in version.py using execfile() and verify that getting the
> version number actually worked.
> 
> Sorry, I did not apply your patch as I had fixed this before even seeing
> your patch.

No worries.  5dc189c seems to be building fine so far...

Cheers,
mwh