Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id CE5A14196F0 for ; Mon, 19 Apr 2010 11:18:53 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lordEtwJV-ZQ; Mon, 19 Apr 2010 11:18:53 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 205D1431FC1; Mon, 19 Apr 2010 11:18:53 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id B4761568DE4; Mon, 19 Apr 2010 11:18:52 -0700 (PDT) From: Carl Worth To: David Edmondson , notmuch Subject: Re: pull request In-Reply-To: <87ljcj2u4z.fsf@yoom.home.cworth.org> References: <87sk722sfq.fsf@ut.hh.sledj.net> <87eiibq22s.fsf@ut.hh.sledj.net> <87ljcj2u4z.fsf@yoom.home.cworth.org> Date: Mon, 19 Apr 2010 11:18:52 -0700 Message-ID: <878w8jpapf.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Apr 2010 18:18:54 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Mon, 19 Apr 2010 11:07:40 -0700, Carl Worth wrote: > On Mon, 19 Apr 2010 09:27:39 +0100, David Edmondson wrote: >=20 > I've got some misgivings about this one. First, notmuch-search-hook is > a hook for the user to manipulate, while the hl-line-mode functionality > is something that should be on by default. That is, if the user happens > to set the search-hook then the hl-line-mode shouldn't magically > disappear. I forgot. The user is expected to use add-hook which avoids this very problem. So this patch is fine. =2DCarl --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD4DBQFLzJ6M6JDdNq8qSWgRApKYAKCkw6V9Sjoyf0RiY+CGB9f/dgV87wCYl+xq KzufyybJIHwyB48cukty8Q== =E+Gg -----END PGP SIGNATURE----- --=-=-=--