Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id BC45D431FAF for ; Sat, 17 Nov 2012 07:49:57 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cVAJNX5TEr8R for ; Sat, 17 Nov 2012 07:49:57 -0800 (PST) Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 24F42431FAE for ; Sat, 17 Nov 2012 07:49:57 -0800 (PST) Received: by mail-qc0-f181.google.com with SMTP id x40so2629135qcp.26 for ; Sat, 17 Nov 2012 07:49:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=dsVbcScMF9Nd3NqmcyYJXgYN92NE/V3wmAWjE8+pQfY=; b=hMg5NfPoL/LMSNdCdgOYSLDXbzmesgXTQdSwGA9ErQ1JUmxvA3FFLIJoroHAT7hZ+0 AU9Uu4upbEaGMkmv6yxqj6KNkzo2CyMYpdw/BftvKacDcc1swd2om/k9Os6+FP7cz0zC 99rzD7GV4Zmb7voSpoxFgWwVPCkxvvZ1PUiW3O+J/xSy6rd06HDess+1J8bPtFaUl8Qg raSwl+EqVu+zS7Odj0nzwXGaTMFoXmJ1vKWMkhhsC8KSQg7HmNKxxeE1n6CEFRW5VQ13 TpcXgjTC0MaldHIpSsPUQ1nVxAmoh0MqR5AGaNi7yo/PMjVimuRzFELQVZOxzhXQuPjG fNSg== Received: by 10.49.28.168 with SMTP id c8mr8344803qeh.62.1353167395618; Sat, 17 Nov 2012 07:49:55 -0800 (PST) Received: from smtp.gmail.com ([66.114.71.21]) by mx.google.com with ESMTPS id r13sm3071233qaa.20.2012.11.17.07.49.53 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 17 Nov 2012 07:49:54 -0800 (PST) From: Ethan Glasser-Camp To: david@tethera.net, notmuch@notmuchmail.org Subject: Re: [PATCH 2/2] test: add nontrivial test for restore --accumulate. In-Reply-To: <1353162631-7947-2-git-send-email-david@tethera.net> References: <8762552dre.fsf@betacantrips.com> <1353162631-7947-1-git-send-email-david@tethera.net> <1353162631-7947-2-git-send-email-david@tethera.net> User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/24.1.1 (x86_64-pc-linux-gnu) Date: Sat, 17 Nov 2012 10:49:53 -0500 Message-ID: <8739082pr2.fsf@betacantrips.com> MIME-Version: 1.0 Content-Type: text/plain Cc: David Bremner X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Nov 2012 15:49:57 -0000 david@tethera.net writes: > From: David Bremner > > It seems we have never tested the case that restore --accumulate > actually adds tags. I noticed this when I started optimizing and no > tests failed. > > The bracketing with "restore --input=dump.expected" are to make sure > we start in a known state, and we leave the database in a known state > for the next test. OK, these LGTM. Ethan