Return-Path: <jani@nikula.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id EABD5431FC7
	for <notmuch@notmuchmail.org>; Sun, 25 May 2014 10:01:53 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Mp3jYaA72+0K for <notmuch@notmuchmail.org>;
	Sun, 25 May 2014 10:01:48 -0700 (PDT)
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com
 [74.125.82.44])	(using TLSv1 with cipher RC4-SHA (128/128 bits))	(No client
 certificate requested)	by olra.theworths.org (Postfix) with ESMTPS id
 433B1431FAF	for <notmuch@notmuchmail.org>; Sun, 25 May 2014 10:01:48 -0700
 (PDT)
Received: by mail-wg0-f44.google.com with SMTP id a1so6824296wgh.3
	for <notmuch@notmuchmail.org>; Sun, 25 May 2014 10:01:46 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=1e100.net; s=20130820;
	h=x-gm-message-state:from:to:cc:subject:in-reply-to:references
	:user-agent:date:message-id:mime-version:content-type;
	bh=fxEpk0jDCCdagO7ZguCRcLaCxOJb2hhCAgOhwkkAob4=;
	b=MHH8GjUr2WBWAChKen5up+VsjwTQL3I+TpD156rpBZsH6tyLZKcXdDuh4hQx0hUkgA
	FMyGzLHF0wwkxNngaO6voqvYOQ4m/uKWOIT3QcTS854mmBVmdszs0cCk1DbV2zNJ+iOa
	VPbAWIbwaqTiGC8pf+NBjkfYDJn1Gd3ujs23znbLJcSwhM1ICZwXI69cT+lyxqnKeV1C
	d3reGpSIF5gEmFz2hwm9ryx2vwuz3Qy0qymOcTDm0TDWdI6Fb9OJbdAUwKQT9/HahMnJ
	9yueQga6nC5HKbjrf0oIQ2DbbwzHd/TgTg9Nt5SX9SYEUpZsnQvw3MpaApYoREzka/rw
	7hUw==
X-Gm-Message-State:
 ALoCoQnN00QoVFeGwiAC7LkBl4j+T1SusUCvUOjm4UPa+8BcyxiY52GGzSJ91az7twfkEypWVUid
X-Received: by 10.180.94.37 with SMTP id cz5mr20407955wib.19.1401037306867;
	Sun, 25 May 2014 10:01:46 -0700 (PDT)
Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi.
	[88.195.111.91])
	by mx.google.com with ESMTPSA id b19sm19636522wic.5.2014.05.25.10.01.45
	for <multiple recipients>
	(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
	Sun, 25 May 2014 10:01:46 -0700 (PDT)
From: Jani Nikula <jani@nikula.org>
To: Felipe Contreras <felipe.contreras@gmail.com>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] build: don't add sub Makefiles to the global deps
In-Reply-To: <5382107e7870f_2275ff3304ec@nysa.notmuch>
References: <1400841267-12807-1-git-send-email-felipe.contreras@gmail.com>
	<1400841267-12807-2-git-send-email-felipe.contreras@gmail.com>
	<87wqdai92o.fsf@nikula.org>
	<5381a172d52b5_d72bf52fc50@nysa.notmuch>
	<87r43ii5dx.fsf@nikula.org>
	<5382107e7870f_2275ff3304ec@nysa.notmuch>
User-Agent: Notmuch/0.18~rc0+2~gbc64cdc (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 25 May 2014 20:01:44 +0300
Message-ID: <87k399iyh3.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain
Cc: Ali Polatel <alip@exherbo.org>
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 25 May 2014 17:01:54 -0000

On Sun, 25 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
> Jani Nikula wrote:
>> On Sun, 25 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>> > Jani Nikula wrote:
>> >> On Fri, 23 May 2014, Felipe Contreras <felipe.contreras@gmail.com> wrote:
>> >> > They don't affect the global build.
>> >> 
>> >> They do.
>> >
>> > They don't.
>> 
>> Your patch, your commit message, please explain *why* you think they
>> wouldn't or shouldn't affect the global build. Just to mention one
>> thing, why someone modifying cflags in sub makefiles shouldn't cause
>> rebuild?
>
> Go to emacs/Makefile, it's basically a stub, why would any modifications
> there affect the global build? It's not included anywhere.
>
> emacs/Makefile.local is included in the global build, emacs/Makefile is
> not.

Fair enough. And what is the benefit of not depending on them, since
they hardly ever change? I'd rather err on the depending side.

BR,
Jani.