From: Mark Walters <markwalters1009@gmail.com>
To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs-hello: Do not calculate the count of the messages
	in hidden sections
In-Reply-To: <1329603149-6047-1-git-send-email-sojkam1@fel.cvut.cz>
References: <874nunokr5.fsf@steelpick.2x.cz>
	<1329603149-6047-1-git-send-email-sojkam1@fel.cvut.cz>
User-Agent: Notmuch/0.11.1+281~g665c451 (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Thu, 01 Mar 2012 22:18:04 +0000
Message-ID: <87y5rk55k3.fsf@qmul.ac.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Sat, 18 Feb 2012 23:12:29 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> The result is that hello screen shows much faster when some sections are
> hidden.
> ---
>  emacs/notmuch-hello.el |   20 ++++++++++----------
>  1 files changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
> index aad373d..e9caade 100644
> --- a/emacs/notmuch-hello.el
> +++ b/emacs/notmuch-hello.el
> @@ -695,16 +695,16 @@ Supports the following entries in OPTIONS as a plist:
>  				(notmuch-hello-update))
>  		     "hide"))
>      (widget-insert "\n")
> -    (let (target-pos
> -	  (searches (apply 'notmuch-hello-query-counts query-alist options)))
> -      (when (and (not is-hidden)
> -	       (or (not (plist-get options :hide-if-empty))
> -		  searches))
> -	(widget-insert "\n")
> -	(setq target-pos
> -	      (notmuch-hello-insert-buttons searches))
> -	(indent-rigidly start (point) notmuch-hello-indent)
> -	target-pos))))
> +    (let (target-pos)
> +      (when (not is-hidden)
> +	(let ((searches (apply 'notmuch-hello-query-counts query-alist options)))
> +	  (when (or (not (plist-get options :hide-if-empty))
> +		    searches)
> +	    (widget-insert "\n")
> +	    (setq target-pos
> +		  (notmuch-hello-insert-buttons searches))
> +	    (indent-rigidly start (point) notmuch-hello-indent))))
> +      target-pos)))
>  
>  (defun notmuch-hello-insert-tags-section (&optional title &rest options)
>    "Insert a section displaying all tags with message counts.


This looks fine to me and does speed things up when the "All tags"
section is hidden (are there other sections I can hide?)

Best wishes

Mark