Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A27D0431FC2 for ; Thu, 22 Aug 2013 10:49:15 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NkzQJCNgsd4U for ; Thu, 22 Aug 2013 10:49:10 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 65FBE431FC4 for ; Thu, 22 Aug 2013 10:49:10 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id ACEA2100086; Thu, 22 Aug 2013 20:49:04 +0300 (EEST) From: Tomi Ollila To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH v3 00/11] contrib: pick: keybindings In-Reply-To: <87fvu14pbr.fsf@qmul.ac.uk> References: <1377191427-6821-1-git-send-email-markwalters1009@gmail.com> <87fvu14pbr.fsf@qmul.ac.uk> User-Agent: Notmuch/0.16+3~g340c058 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Aug 2013 17:49:16 -0000 On Thu, Aug 22 2013, Mark Walters wrote: > Here is the diff diff that I should have included in the previous email LGTM. > Sorry about that! > > Mark Tomi > > diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el > index 3b86a5a..37dc161 100644 > --- a/contrib/notmuch-pick/notmuch-pick.el > +++ b/contrib/notmuch-pick/notmuch-pick.el > @@ -198,7 +198,7 @@ open (if the message pane is closed it does nothing)." > (interactive) > (when (window-live-p notmuch-pick-message-window) > (with-selected-window notmuch-pick-message-window > - (funcall #',func))))) > + (call-interactively #',func))))) > > (defun notmuch-pick-button-activate (&optional button) > "Activate BUTTON or button at point > @@ -218,7 +218,7 @@ FUNC." > ,(concat "(Close message pane and) " (documentation func t)) > (interactive) > (notmuch-pick-close-message-window) > - (funcall #',func))) > + (call-interactively #',func))) > > (defvar notmuch-pick-mode-map > (let ((map (make-sparse-keymap))) > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch