Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 5CD6F431FBD
	for <notmuch@notmuchmail.org>; Sat, 22 Feb 2014 02:17:37 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 2w1GlIgtZV4S for <notmuch@notmuchmail.org>;
	Sat, 22 Feb 2014 02:17:33 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 7B296431FB6
	for <notmuch@notmuchmail.org>; Sat, 22 Feb 2014 02:17:33 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 03EDF10005E;
	Sat, 22 Feb 2014 12:17:25 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/4] emacs: Simplify and fix
	`notmuch-mua-prompt-for-sender'
In-Reply-To: <1392923797-17045-5-git-send-email-amdragon@mit.edu>
References: <1392923797-17045-1-git-send-email-amdragon@mit.edu>
	<1392923797-17045-5-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.17+94~g1b90823 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sat, 22 Feb 2014 12:17:24 +0200
Message-ID: <m28ut3cuyz.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Cc: bjonnh-nm@bjonnh.net
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Feb 2014 10:17:37 -0000

On Thu, Feb 20 2014, Austin Clements <amdragon@MIT.EDU> wrote:

This seris LGTM. I don't know about patch 4 as I have not used
the features (hand-edited From: always...)  maybe I should...

Tomi


> This patch rewrites `notmuch-mua-prompt-for-sender' to simply prompt
> for a full identity, where the list of identities is derived from
> either notmuch-identities or the user's Notmuch configuration.
>
> The original code also did several strange things, like using `eval'
> and specifying that this function was interactive.  As a side-effect,
> this patch fixes these problems.  And it adds a docstring.
> ---
>  emacs/notmuch-mua.el | 33 +++++++++------------------------
>  1 file changed, 9 insertions(+), 24 deletions(-)
>