From: Carl Worth <cworth@cworth.org>
To: James Westby <jw+debian@jameswestby.net>, notmuch@notmuchmail.org
Subject: Re: [notmuch] [PATCH] Store thread ids for messages that we haven't
	seen yet
In-Reply-To: <874ojftldt.fsf@jameswestby.net>
References: <87fx72o8pq.fsf@yoom.home.cworth.org>
	<1268515677-12692-1-git-send-email-jw+debian@jameswestby.net>
	<87sk6ze5v3.fsf@yoom.home.cworth.org>
	<874ojftldt.fsf@jameswestby.net>
Date: Wed, 14 Apr 2010 17:39:40 -0700
Message-ID: <87hbndft0z.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=

On Tue, 13 Apr 2010 16:36:30 +0100, James Westby <jw+debian@jameswestby.net> wrote:
> Your choice. I prefer putting them in the same commit to be more
> self-documenting, and then using the capabilities of my VCS to verify
> the change if i desire.

But that's my point. With it split, I can actually use "git checkout" to
go to a state where the test exists, but the bug hasn't been fixed. With
it combined, there's no such state. (I can checkout state with the bug,
but then there's nothing in the test suite to exercise it.)

> This would fix up threads for all existing messages?

Yes. It seems un-right for notmuch to provide a feature on an arbitrary
subset of messages, (those that happened to be added after the user
switched to some particular version of notmuch).

> Probably a good thing to have, but not that important to me. In my
> case I can always open the bug in my browser if I want to see the full
> conversation.

I agree it's not totally essential. But it should be easy enough to pick
up in the upcoming database upgrade, (which may actually end up being a
full rebuild anyway---I've got a lot of things to change and a full
rebuild might be the fastest thing to do).

-Carl

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFLxmBM6JDdNq8qSWgRAkG2AJ9i7xjaCjLiHc7w7CJSH5nWT5OvUACeLvLR
j9jG6Ep8MZOzhAADs7b5v8k=
=RTHl
-----END PGP SIGNATURE-----
--=-=-=--