From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Don't signal an error when reaching the end of the
	search results.
In-Reply-To: <1324370714-28545-1-git-send-email-dme@dme.org>
References: <1324370714-28545-1-git-send-email-dme@dme.org>
User-Agent: Notmuch/0.10.2+123~g49af79c (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
Date: Wed, 28 Dec 2011 22:33:09 +0200
Message-ID: <yf662h0mo6y.fsf@taco2.nixu.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Tue, 20 Dec 2011 08:45:14 +0000, David Edmondson <dme@dme.org> wrote:
> With the default configuration ('space' moves through the messages
> matching the search and back to the results index at the end) it's
> unnecessary to signal an error when the last message has been read, as
> this is the common case.
> 
> Moreover, it's very annoying when `debug-on-error' is t.
> ---

I'd say '+1' but I could not reproduce the case. In case this is case
that should not happen then I just don't know whetner emacs should
signal error to user or not.

Tomi

>  emacs/notmuch.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 675a110..2e9973e 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -438,7 +438,7 @@ Complete list of currently available key bindings:
>  				 "*")
>  			 32 nil nil t))
>  		      crypto-switch)
> -      (error "End of search results"))))
> +      (message "End of search results."))))
>  
>  (defun notmuch-search-reply-to-thread (&optional prompt-for-sender)
>    "Begin composing a reply to the entire current thread in a new buffer."
> -- 
> 1.7.7.3