Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C7874409F24 for ; Fri, 6 Jan 2012 23:31:38 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ljgEtkjvzolL for ; Fri, 6 Jan 2012 23:31:38 -0800 (PST) Received: from mail-pz0-f53.google.com (mail-pz0-f53.google.com [209.85.210.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 05B80409F22 for ; Fri, 6 Jan 2012 23:31:37 -0800 (PST) Received: by dady9 with SMTP id y9so3170649dad.26 for ; Fri, 06 Jan 2012 23:31:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.68.74.10 with SMTP id p10mr21813949pbv.3.1325921495682; Fri, 06 Jan 2012 23:31:35 -0800 (PST) Received: by 10.68.58.7 with HTTP; Fri, 6 Jan 2012 23:31:35 -0800 (PST) Received: by 10.68.58.7 with HTTP; Fri, 6 Jan 2012 23:31:35 -0800 (PST) In-Reply-To: <87sjjsjhjk.fsf@zancas.localnet> References: <974a2ef1f1df7d93e0b5bd642ca8a49f8b727a86.1325794371.git.jani@nikula.org> <87sjjsjhjk.fsf@zancas.localnet> Date: Sat, 7 Jan 2012 09:31:35 +0200 Message-ID: Subject: Re: [PATCH 1/4] cli: fix use of uninitialized variable in "notmuch reply" From: Jani Nikula To: David Bremner Content-Type: multipart/alternative; boundary=f46d04138ecdc00d7104b5eb277e Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2012 07:31:39 -0000 --f46d04138ecdc00d7104b5eb277e Content-Type: text/plain; charset=UTF-8 On Jan 7, 2012 5:52 AM, "David Bremner" wrote: > > On Thu, 5 Jan 2012 22:25:12 +0200, Jani Nikula wrote: > > notmuch_show_params_t params is only initialized partially in > > notmuch_reply_command(). The only field that is used uninitialized is > > params.decrypt. It is usually non-zero, making "notmuch reply" on encrypted > > messages work by coincidence. > > Hi Jani; > > I get one test failure with this patch on current master: Can't investigate right now, but did you try with just patch 1/4? (I really should have separated the bug fix from the rest.) J. > > FAIL Reply within emacs > --- emacs.24.expected 2012-01-07 03:47:50.000000000 +0000 > +++ emacs.24.output 2012-01-07 03:47:50.000000000 +0000 > @@ -1,5 +1,5 @@ > From: Notmuch Test Suite > -To: user@example.com > +To: > Subject: Re: Testing message sent via SMTP > In-Reply-To: > Fcc: /tmp/notmuch-dev-bremner/test/tmp.emacs/mail/sent > > d --f46d04138ecdc00d7104b5eb277e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable


On Jan 7, 2012 5:52 AM, "David Bremner" <david@tethera.net> wrote:
>
> On Thu, =C2=A05 Jan 2012 22:25:12 +0200, Jani Nikula <jani@nikula.org> wrote:
> > notmuch_show_params_t params is only initialized partially in
> > notmuch_reply_command(). The only field that is used uninitialize= d is
> > params.decrypt. It is usually non-zero, making "notmuch repl= y" on encrypted
> > messages work by coincidence.
>
> Hi Jani;
>
> I get one test failure with this patch on current master:

Can't investigate right now, but did you try with just patch 1/4? (I= really should have separated the bug fix from the rest.)

J.

>
> =C2=A0FAIL =C2=A0 Reply within emacs
> =C2=A0 =C2=A0 =C2=A0 =C2=A0--- emacs.24.expected =C2=A0 2012-01-07 03:= 47:50.000000000 +0000
> =C2=A0 =C2=A0 =C2=A0 =C2=A0+++ emacs.24.output =C2=A0 =C2=A0 2012-01-0= 7 03:47:50.000000000 +0000
> =C2=A0 =C2=A0 =C2=A0 =C2=A0@@ -1,5 +1,5 @@
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 From: Notmuch Test Suite <test_suite@notmuchmail.org>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0-To: us= er@example.com
> =C2=A0 =C2=A0 =C2=A0 =C2=A0+To:
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 Subject: Re: Testing message sent via SMTP=
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 In-Reply-To: <XXX>
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 Fcc: /tmp/notmuch-dev-bremner/test/tmp.ema= cs/mail/sent
>
> d

--f46d04138ecdc00d7104b5eb277e--