From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Peter Feigl <craven@gmx.net>
Subject: Re: [PATCH] rewriting notmuch-search for structured output to make
	other output formats easier
In-Reply-To: <87lip0ljzy.fsf@nexoid.at>
References: <1327180568-30385-1-git-send-email-craven@gmx.net>
	<87k44klkee.fsf@servo.finestructure.net> <87lip0ljzy.fsf@nexoid.at>
User-Agent: Notmuch/0.11+92~g9b8f34f (http://notmuchmail.org) Emacs/23.3.1
	(x86_64-pc-linux-gnu)
Date: Sat, 21 Jan 2012 16:34:03 -0800
Message-ID: <87hazolgn8.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=

On Sun, 22 Jan 2012 00:21:37 +0100, "Peter Feigl" <craven@gmx.net> wrote:
> What kind of documentation should I include?

Update the man page to describe the new format and command line options.

> The test suite should work fine, *if* it compares EXPECTED and OUTPUT
> not character-by-character, but rather by pretty-printing both the
> expected and the actual outputs by some JSON pretty-printer (like python
> -mjson.tool). I can of course provide additional test-cases for
> --format=sexp.

I was referring specifically to new tests for the new output format.
The test suite changes should include only additions, since as you point
out, the internal restructuring shouldn't affect any existing tests.

> How should I proceed on this? Re-submit the patch with the sexp-support
> removed and only JSON updated?

I think you should primarily work on addressing Austin's issues
regarding the output formatters first, being careful to try to make more
small atomic patches.  Then once that's done make a new series of
patches, depending on the new formatter patches, that adds the new
output format.

As Austin points out, more smaller patches that are narrowly focused are
much easier to review, even if there ends up being more changes in the
end.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAEBCAAGBQJPG1l7AAoJEO00zqvie6q8oQ8QAJglbb70lsYZzBLhLVxERiva
YgmLbOCZKmjVAxkeiZ4BMH7uCJrZexgmrsJ2pfimErxPVlrbu7hw/b2eyprv/dkU
q+J9bAMjNCHtgWUWBeG2Bpv7LxFN/k6IwBnmEgqsimp+6E4kel3Enr8QrOLsWpeV
oAD2kMaRrsmyzP84n//EnZ5gahIMcuMLfZzHtkobPcagtZh4e/b7HMiC/8yG2qXA
JTpmQokYrC/jPIENQbOd2q7SR5KYUAQqhnUfkOYea2PtUiMdEv7pRY15X9+5zC8V
ZxiC2CRx4ARMc9qrO/FIPfUKDMXi9CZqAu+rgBhwhxdeeQcoaf7gEfykrHONMNz1
Gs63e/vVUuhfh8/8T1JqAk/yj2ty6cjsB/Gow5RBuELmyzQZMxLepa8Az3j+tQge
zvRW+TElbUY7ULqWDwwBwXX3Qjk7OXmWbfyJjCheMWNPJJ5gzZTY79X9Kj6DP+eZ
APFj1uejS//G87q+fmeomuz4Wijk6RC+C6PMDhaST7m/4BylZMbU0QAziqenuSGN
hncu0VRN66AZOn1Cjpid3AWl+2eALi9B0bp7Ndh2jgXsoP2ifNWn6AowidfFX560
tlYncj3d9k2wfYPCkm5lbgwNsqlrZdolB43UlFX42XGQjyL2VkY+IC8fpjqiudCi
NzHEoKYEbuSCYW7ANAFr
=uIhi
-----END PGP SIGNATURE-----
--=-=-=--