Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 970EC40D150 for ; Fri, 29 Oct 2010 15:56:27 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.89 X-Spam-Level: X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01] autolearn=ham Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hIhT00ea4jUC; Fri, 29 Oct 2010 15:56:17 -0700 (PDT) Received: from yoom.home.cworth.org (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 30FCE40D149; Fri, 29 Oct 2010 15:56:17 -0700 (PDT) Received: by yoom.home.cworth.org (Postfix, from userid 1000) id B813F254007; Fri, 29 Oct 2010 15:56:16 -0700 (PDT) From: Carl Worth To: David Edmondson , Dirk Hohndel , notmuch Subject: Re: fix problem with notmuch-hello-nice-number In-Reply-To: <87mxv3s6za.fsf@ut.hh.sledj.net> References: <87mxv3s6za.fsf@ut.hh.sledj.net> User-Agent: Notmuch/0.3.1 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Fri, 29 Oct 2010 15:56:16 -0700 Message-ID: <877hh0r4kv.fsf@yoom.home.cworth.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Oct 2010 22:56:27 -0000 --=-=-= Content-Transfer-Encoding: quoted-printable On Thu, 10 Jun 2010 08:05:13 +0100, David Edmondson wrote: > On Wed, 09 Jun 2010 07:49:01 -0700, Dirk Hohndel = wrote: > > Without this little patch notmuch fails with current git if there's a > > saved search that has zero results >=20 > How about: ... > (setq n (/ n 1000))) > + (setq result (or result '(0))) > (apply #'concat Thanks Dirk and David, I've just pushed this version (finally!) of this nearly-trivial patch From=20so long ago. The bug hasn't been as important lately since by default notmuch doesn't even display saved searches with 0 results. But the bug was still present for anyone that set notmuch-show-empty-saved-searches to a non-nil value. I've also added a test to the test suite to ensure this case gets exercised there. Thanks again, =2DCarl =2D-=20 carl.d.worth@intel.com --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iD8DBQFMy1EQ6JDdNq8qSWgRAnF/AJ9m6X6OWB9PXoL7cM/0oTbRw0bDaQCfVafH gJCngHePEvck4wQNgcbU1AA= =xBKn -----END PGP SIGNATURE----- --=-=-=--