Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 51C19431FAF
	for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 23:19:38 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id dFXtwX6UTmOB for <notmuch@notmuchmail.org>;
	Mon, 26 Mar 2012 23:19:37 -0700 (PDT)
Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
	by olra.theworths.org (Postfix) with ESMTP id 69F9D431FAE
	for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 23:19:37 -0700 (PDT)
Received: by guru.guru-group.fi (Postfix, from userid 501)
	id 1D60168055; Tue, 27 Mar 2012 09:19:34 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: Fix mis-named argument to
	notmuch-get-bodypart-internal
In-Reply-To: <1332812426-26684-1-git-send-email-amdragon@mit.edu>
References: <1332812426-26684-1-git-send-email-amdragon@mit.edu>User-Agent:
 Notmuch/0.12+68~g2b97293	(http://notmuchmail.org) Emacs/23.3.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Tue, 27 Mar 2012 09:19:34 +0300
Message-ID: <m2vclqtvk9.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Mar 2012 06:19:38 -0000

On Tue, Mar 27 2012, Austin Clements <amdragon@MIT.EDU> wrote:

> Previously, this function took an argument called "message-id", even
> though it was a general query, rather than a message ID.  This changes
> it to "query".
> ---

+1 

Tomi


>  emacs/notmuch-lib.el |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
> index 2e367b5..4b17ecc 100644
> --- a/emacs/notmuch-lib.el
> +++ b/emacs/notmuch-lib.el
> @@ -219,13 +219,13 @@ the given type."
>  
>  ;; Helper for parts which are generally not included in the default
>  ;; JSON output.
> -(defun notmuch-get-bodypart-internal (message-id part-number process-crypto)
> +(defun notmuch-get-bodypart-internal (query part-number process-crypto)
>    (let ((args '("show" "--format=raw"))
>  	(part-arg (format "--part=%s" part-number)))
>      (setq args (append args (list part-arg)))
>      (if process-crypto
>  	(setq args (append args '("--decrypt"))))
> -    (setq args (append args (list message-id)))
> +    (setq args (append args (list query)))
>      (with-temp-buffer
>        (let ((coding-system-for-read 'no-conversion))
>  	(progn
> -- 
> 1.7.7.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch