From: Carl Worth <cworth@cworth.org>
To: Mike Kelly <pioto@pioto.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] notmuch-setup.c: Initialize getline(3) response_size to 0
In-Reply-To: <1287080299-13828-1-git-send-email-pioto@pioto.org>
References: <20101013094340.41580a2f@pioto.org>
	<1287080299-13828-1-git-send-email-pioto@pioto.org>
User-Agent: Notmuch/0.3.1-137-gce6390c (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Fri, 29 Oct 2010 13:15:42 -0700
Message-ID: <87y69g69ht.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Thu, 14 Oct 2010 14:18:19 -0400, Mike Kelly <pioto@pioto.org> wrote:
> This appears to be necessary on FreeBSD. If this isn't done, we get a
> nasty segfault.

Thanks. I've pushed this out.

I didn't have that initialized originally, because the documentation I
have for getline on my Linux machine says explicitly:

       If *lineptr is NULL, then getline() will allocate a buffer for
       storing the line, which should be freed by the user program.  (In
       this case, the value in *n is ignored.)

But, oh well, it's easy enough to fix.

Thanks again for the patch.

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iD8DBQFMyytu6JDdNq8qSWgRAgoJAJ9L0zgJZ51Rr8W8qfNr/Ym0jU+kYQCdHqEJ
ftJkKaADS0hVzu70xczA5YU=
=O55N
-----END PGP SIGNATURE-----
--=-=-=--