Date: Sat, 16 Jul 2011 14:32:36 -0400
From: Austin Clements <amdragon@MIT.EDU>
To: Felipe Contreras <felipe.contreras@gmail.com>
Subject: Re: [PATCH 1/3] lib: Kill last usage of C++ type bool
Message-ID: <20110716181608.GL25558@mit.edu>
References: <1310479190-6973-1-git-send-email-l.rilling@av7.net>
	<1310479190-6973-2-git-send-email-l.rilling@av7.net>
	<CAMP44s3abtAJ94u6DxNtt9TJHCXxEjoFH5SCG9PEGcPbowUjxg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To:
 <CAMP44s3abtAJ94u6DxNtt9TJHCXxEjoFH5SCG9PEGcPbowUjxg@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: notmuch@notmuchmail.org
Precedence: list

Quoth Felipe Contreras on Jul 16 at  9:06 pm:
> On Tue, Jul 12, 2011 at 4:59 PM, Louis Rilling <l.rilling@av7.net> wrote:
> > Signed-off-by: Louis Rilling <l.rilling@av7.net>
> > ---
> >  lib/message.cc |   12 ++++++------
> >  1 files changed, 6 insertions(+), 6 deletions(-)
> >
> > diff --git a/lib/message.cc b/lib/message.cc
> > index d993cde..cf651e5 100644
> > --- a/lib/message.cc
> > +++ b/lib/message.cc
> > @@ -49,16 +49,16 @@ struct visible _notmuch_message {
> >  struct maildir_flag_tag {
> >     char flag;
> >     const char *tag;
> > -    bool inverse;
> > +    notmuch_bool_t inverse;
> 
> That's not C++, that's C99.

Here it's C++.  But what's actually interesting is that this is the
only place where libnotmuch strays from completely consistent use of
notmuch_bool_t.