From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org,
	Mark Walters <markwalters1009@gmail.com>
Subject: Re: [PATCH] cli: mime node: fix compiler warning when building
	against gmime 2.4
In-Reply-To: <1365248863-17947-1-git-send-email-jani@nikula.org>
References: <1365248863-17947-1-git-send-email-jani@nikula.org>
User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Sun, 07 Apr 2013 22:07:42 +0300
Message-ID: <m2ip3yi2gx.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list

On Sat, Apr 06 2013, Jani Nikula <jani@nikula.org> wrote:

> commit d487ef9e58bcd193118f19f771d5ef3984616be5
> Author: Jani Nikula <jani@nikula.org>
> Date:   Sat Mar 30 15:53:16 2013 +0200
>
>     cli: mime node: abstract decryption and signature verification
>
> introduced a compiler warning, reported by Mark Walters, when building
> against gmime 2.4:
>
> mime-node.c:224:9: warning: assignment discards =E2=80=98const=E2=80=99 q=
ualifier from
> pointer target type [enabled by default]
>
> Pass the non-const signature validity to the destructor to fix this.
>
> ---
>
> Not even compile tested as I don't have gmime 2.4 on any
> systems... Mark, please build and run the tests with this. Thanks.

I can confirm this patch removes the compilation warning. I looked the
impmementation though the glasses which say gmime-2.4 support is going
to be deprecated in somewhat near future and I think it is good.

Tomi


> ---
>  mime-node.c |   13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/mime-node.c b/mime-node.c
> index 851f963..fd9e4a4 100644
> --- a/mime-node.c
> +++ b/mime-node.c
> @@ -217,11 +217,12 @@ _signature_validity_free (GMimeSignatureValidity **=
proxy)
>=20=20
>  /* Set up signature validity destructor (GMime 2.4) */
>  static void
> -set_signature_validity_destructor (mime_node_t *node)
> +set_signature_validity_destructor (mime_node_t *node,
> +				   GMimeSignatureValidity *sig_validity)
>  {
>      GMimeSignatureValidity **proxy =3D talloc (node, GMimeSignatureValid=
ity *);
>      if (proxy) {
> -	*proxy =3D node->sig_validity;
> +	*proxy =3D sig_validity;
>  	talloc_set_destructor (proxy, _signature_validity_free);
>      }
>  }
> @@ -232,12 +233,14 @@ node_verify (mime_node_t *node, GMimeObject *part,
>  	     notmuch_crypto_context_t *cryptoctx)
>  {
>      GError *err =3D NULL;
> +    GMimeSignatureValidity *sig_validity;
>=20=20
>      node->verify_attempted =3D TRUE;
> -    node->sig_validity =3D g_mime_multipart_signed_verify
> +    sig_validity =3D g_mime_multipart_signed_verify
>  	(GMIME_MULTIPART_SIGNED (part), cryptoctx, &err);
> -    if (node->sig_validity) {
> -	set_signature_validity_destructor (node);
> +    node->sig_validity =3D sig_validity;
> +    if (sig_validity) {
> +	set_signature_validity_destructor (node, sig_validity);
>      } else {
>  	fprintf (stderr, "Failed to verify signed part: %s\n",
>  		 err ? err->message : "no error explanation given");
> --=20
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch