From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: bugfix unquoted symbol
In-Reply-To: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com>
References: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.16+77~g2561895 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
Date: Sun, 15 Sep 2013 10:32:24 +0300
Message-ID: <m21u4qa6bb.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: list

On Sat, Sep 14 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> In the recent changes for search order handling the default-value of
> notmuch-search-oldest-first was used. However, default-value needs a
> symbol so the symbol-name needs to be quoted.
>
> This missing quote was causing strange sort-orders in some cases.
> ---
>
> I think this is clearly correct (and what was intended) and it seems
> to work as expected.

Marked ready.

>
> Best wishes
>
> Mark
>

Tomi

>
>
>
>  emacs/notmuch.el |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index 4de6229..0ff248b 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -888,7 +888,7 @@ the configured default sort order."
>      nil
>      ;; Use the default search order (if we're doing a search from a
>      ;; search buffer, ignore any buffer-local overrides)
> -    (default-value notmuch-search-oldest-first)))
> +    (default-value 'notmuch-search-oldest-first)))
>  
>    (let* ((query (or query (notmuch-read-query "Notmuch search: ")))
>  	 (buffer (get-buffer-create (notmuch-search-buffer-title query))))
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch