To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] emacs: support defining a list of alternative parts
	to show
In-Reply-To:
 <fe86d0e2cf0d236615613fa16d94c94fb2120729.1328719309.git.jani@nikula.org>
References: <cover.1328719309.git.jani@nikula.org>
	<fe86d0e2cf0d236615613fa16d94c94fb2120729.1328719309.git.jani@nikula.org>
User-Agent: Notmuch/0.11.1+166~g546cb24 (http://notmuchmail.org)
	Emacs/24.0.92.1 (x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Wed, 08 Feb 2012 17:05:39 +0000
Message-ID: <cunwr7x2r30.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Wed,  8 Feb 2012 16:55:15 +0000, Jani Nikula <jani@nikula.org> wrote:
> Make notmuch-show-all-multipart/alternative-parts accept a list of
> multipart/alternative types to show in addition to the preferred
> types. This allows the user to force display some alternative part
> types while normally showing just the preferred ones.
>=20
> Signed-off-by: Jani Nikula <jani@nikula.org>
> ---
>  emacs/notmuch-show.el |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
>=20
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index faa9f9b..1340380 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -97,7 +97,9 @@ any given message."
>  ;; Mostly useful for debugging.
>  (defcustom notmuch-show-all-multipart/alternative-parts t
>    "Should all parts of multipart/alternative parts be shown?"
> -  :type 'boolean
> +  :type '(choice (const :tag "Show all" t)
> +		 (const :tag "Show preferred" nil)
> +		 (repeat :tag "Show preferred and custom" string))
>    :group 'notmuch-show)

It would be convenient if this was a list of regexps.

>  (defcustom notmuch-show-indent-messages-width 1
> @@ -513,7 +515,9 @@ current buffer, if possible."
>      ;; should be chosen if there are more than one that match?
>      (mapc (lambda (inner-part)
>  	    (let ((inner-type (plist-get inner-part :content-type)))
> -	      (if (or notmuch-show-all-multipart/alternative-parts
> +	      (if (or (equal notmuch-show-all-multipart/alternative-parts t)
> +		      (member inner-type
> +			      notmuch-show-all-multipart/alternative-parts)
>  		      (string=3D chosen-type inner-type))
>  		  (notmuch-show-insert-bodypart msg inner-part depth)
>  		(notmuch-show-insert-part-header (plist-get inner-part :id) inner-type=
 inner-type nil " (not shown)"))))
> --=20
> 1.7.1
>=20

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8yq2MACgkQaezQq/BJZRajrQCeMK9QtMd4s5nKpcPleoKB/y6r
nwUAn3A4etEY/XCwUiIC3bHknCPkSLLM
=f2D7
-----END PGP SIGNATURE-----
--=-=-=--