From: Tomi Ollila <tomi.ollila@iki.fi>
To: Pieter Praet <pieter@praet.org>,
	Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
	Ethan Glasser-Camp <glasse@cs.rpi.edu>
Subject: Re: [PATCH] test: always report missing prereqs,
	independent of `--verbose' option
In-Reply-To: <1326889181-32311-1-git-send-email-pieter@praet.org>
References: <87d3aj8rcl.fsf@gmail.com>
	<1326889181-32311-1-git-send-email-pieter@praet.org>
User-Agent: Notmuch/0.11+71~gefa5d6c (http://notmuchmail.org) Emacs/23.3.1
	(i686-pc-linux-gnu)
Date: Wed, 18 Jan 2012 15:53:59 +0200
Message-ID: <yf64nvtce14.fsf@taco2.nixu.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Notmuch Mail <notmuch@notmuchmail.org>
Precedence: list

On Wed, 18 Jan 2012 13:19:41 +0100, Pieter Praet <pieter@praet.org> wrote:
> When tests are skipped due to missing prereqs, those prereqs are only
> displayed when running with the `--verbose' option.  This is essential
> information when troubleshooting, so always send to stdout.
> 
> ---

Instead of this the test suite could be enchanged so that
full log of the execution is stored somewhere and path
to that file is displayed at the end of test. Generally,
all output could stay available after tests exit so that
those could be investigated furtner.

(I tried to grep 'missing prerequisites' after running test
but did not find the info. the file opened for >&3 has been
deleted already?)

Now I just see huge amounts of missing prerequisites: emacs(1)
in my output (I presume that doesn't happen due to my
hack to "hide" emacs).

But well, I'm not against applying this patch -- just that
the test system starts to get so rotten touching it gives
shivers...

Tomi

> 
>  test/test-lib.sh |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index d1fbc05..6560628 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -673,8 +673,8 @@ test_skip () {
>  
>  test_check_missing_external_prereqs_ () {
>  	if test -n "$test_subtest_missing_external_prereqs_"; then
> -		say_color skip >&3 "missing prerequisites:"
> -		echo "$test_subtest_missing_external_prereqs_" >&3
> +		say_color skip >&1 "missing prerequisites:"
> +		echo "$test_subtest_missing_external_prereqs_" >&1
>  		test_report_skip_ "$@"
>  	else
>  		false
> -- 
> 1.7.8.1