Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id A9AFA431FC2
	for <notmuch@notmuchmail.org>; Sat, 10 May 2014 14:08:23 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id adRu281i01dt for <notmuch@notmuchmail.org>;
	Sat, 10 May 2014 14:08:17 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id ACA75431FBF
	for <notmuch@notmuchmail.org>; Sat, 10 May 2014 14:08:17 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 88A321000E5;
	Sun, 11 May 2014 00:08:10 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: "W. Trevor King" <wking@tremily.us>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/5] nmbug-status fixups from notmuch-to-html
In-Reply-To: <cover.1399748615.git.wking@tremily.us>
References: <cover.1399748615.git.wking@tremily.us>
User-Agent: Notmuch/0.18+11~gbc95cc5 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 11 May 2014 00:08:10 +0300
Message-ID: <m28uq9ibph.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 10 May 2014 21:08:23 -0000

On Sat, May 10 2014, "W. Trevor King" <wking@tremily.us> wrote:

> I've cherry-picked the three patches I liked from Carl's master [1,2]
> and added two cleanup commits of my own.  I've left Carl's commit
> messages unchanged.  I'm fine squashing my fixups into Carl's
> originals (leaving Carl as the author) if that's ok with him.

I think the series is good as it is.

I like seeing something after last patch at the end of the page -- It makes
it easier to notice when patches end. Perhaps I  get used to see date
there.

The rendered <hr/> irritates me a bit, though. Maybe it could be colored
light gray ?

> Cheers,
> Trevor

Tomi


>
> [1]: id:20140423001824.GM9243@odin.tremily.us
>      http://thread.gmane.org/gmane.mail.notmuch.general/17986/focus=17994
> [2]: git://git.cworth.org/git/notmuch-to-html
>
> Carl Worth (3):
>   Add explicit license information
>   Move the generated date from the top of the page to the footer.
>   Add a comment describing the program
>
> W. Trevor King (2):
>   nmbug-status: Use a triple-quoted string for the footer template
>   nmbug-status: Shift the script description into a docstring
>
>  devel/nmbug/nmbug-status | 36 +++++++++++++++++++++++++++++-------
>  1 file changed, 29 insertions(+), 7 deletions(-)
>
> -- 
> 1.9.1.353.gc66d89d