From: Carl Worth <cworth@cworth.org>
To: Austin Clements <amdragon@mit.edu>
Subject: Re: [PATCH 0/5] Fetch all message metadata in a single pass
In-Reply-To: <AANLkTi=uZXTacQFiUUk8k5h17NrV1wTo5OR7T=3UguE_@mail.gmail.com>
References: <1291928396-27937-1-git-send-email-amdragon@mit.edu>
	<AANLkTiknTgHruLKKYsVo-r9319VHxmuXcw5oxOLPzHQ_@mail.gmail.com>
	<87hbba8ggp.fsf@yoom.home.cworth.org>
	<AANLkTi=uZXTacQFiUUk8k5h17NrV1wTo5OR7T=3UguE_@mail.gmail.com>
User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.2.1
	(i486-pc-linux-gnu)
Date: Mon, 25 Apr 2011 13:52:04 -0700
Message-ID: <87oc3u3vgr.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Transfer-Encoding: quoted-printable

On Mon, 21 Mar 2011 02:56:05 -0400, Austin Clements <amdragon@mit.edu> wrot=
e:
> Thanks for the thorough review.  My updated patches are on the
> eager-metadata-v4 branch (also, for-review/eager-metadata-v4) at
>   http://awakening.csail.mit.edu/git/notmuch.git

Great. I failed at my commitment to quickly apply the updated series. I
want to do it now, but I'm failing to be able to fetch the code:

	$ git fetch amdragon
	error: RPC failed; result=3D22, HTTP code =3D 417
	fatal: The remote end hung up unexpectedly

(This is using the URL above.)

> This doesn't cause any problems in the one weird case that still needs
> the reference to the list.  After the _notmuch_tags_create, the caller
> simply adds that reference.

This, (and the other comments you made about the cleanup), all sound
great to me. So I'm looking forward to seeing the code.

> Heh, fixed.  I suppose I hadn't been thinking about it, since none of
> the source in lib/ has other authors listed.
>=20
> But it raises an interesting question.  When is it kosher to add
> oneself to a file's author list?  In this case I wrote about half of
> the code in that admittedly short file, so that makes sense  Changing
> a few lines presumably isn't enough.  Adding a few functions?

My intention is simply to leave this up to the author of the code in
question. If you feel your name belongs on the author list, then please
put it there.

Similarly, if you think your code is sufficient to deserve copyright
protection, (so probably anything beyond simple typo fixes or otherwise
tiny changes), then *please* add your name (or your employer's name as
appropriate) to that list as well.

A quick check with grep shows that I've definitely not been asking for
this attribution as much as I should have. Hopefully we can all get in a
better habit going forward.

=2DCarl

=2D-=20
carl.d.worth@intel.com

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iD8DBQFNtd706JDdNq8qSWgRAnPgAJ4hW0yQFMjdq5cRswEfSgsj2Yo4bQCfXrt4
d+7R347ReGKfcec/iIJbujQ=
=9nKU
-----END PGP SIGNATURE-----
--=-=-=--