Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1B29E431FD0 for ; Wed, 20 Jul 2011 10:07:28 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EFce6konoSQd for ; Wed, 20 Jul 2011 10:07:26 -0700 (PDT) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 46B95431FB6 for ; Wed, 20 Jul 2011 10:07:26 -0700 (PDT) Received: from convex-new.cs.unb.ca ([131.202.13.41]) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p6KH7Oer006782; Wed, 20 Jul 2011 14:07:24 -0300 Received: from bremner by convex-new.cs.unb.ca with local (Exim 4.72) (envelope-from ) id 1QjaF2-0004Zj-Hk; Wed, 20 Jul 2011 14:07:24 -0300 From: David Bremner To: Thomas Jost , notmuch@notmuchmail.org Subject: Re: [PATCH] libnotmuch: only build symbols list after the modules are built In-Reply-To: <1311165498-12519-1-git-send-email-schnouki@schnouki.net> References: <1311165498-12519-1-git-send-email-schnouki@schnouki.net> User-Agent: Notmuch/0.6db1 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Wed, 20 Jul 2011 14:07:24 -0300 Message-ID: <87aac8ev8z.fsf@convex-new.cs.unb.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2011 17:07:28 -0000 On Wed, 20 Jul 2011 14:38:18 +0200, Thomas Jost wrote: > If the notmuch.sym target does not explicitly depend on $(libnotmuch_modules), > gen-version-script.sh may be run before all the .o files are created. This can > be observed when doing a parallel build on a machine with many cores: > $ make -j > ... > sh lib/gen-version-script.sh lib/notmuch.h lib/filenames.o lib/string-list.o > lib/libsha1.o lib/message-file.o lib/messages.o lib/sha1.o lib/tags.o > lib/xutil.o lib/database.o lib/directory.o lib/index.o lib/message.o Hi Thomas; Your patch looks sensible. If you could shorten up the commit message a bit, probably by putting the make output after '---' and adjusting the rest of the text, I'll be happy to push it. d