From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Jani Nikula <jani@nikula.org>, David Bremner <david@tethera.net>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] notmuch-new: block database upgrades in default
	configuration.
In-Reply-To: <87ppldrocd.fsf@nikula.org>
References: <87bnx4jyyp.fsf@servo.finestructure.net>
	<1395541573-2417-1-git-send-email-david@tethera.net>
	<1395541573-2417-3-git-send-email-david@tethera.net>
	<87ppldrocd.fsf@nikula.org>
User-Agent: Notmuch/0.17+134~g31849a1 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Sun, 23 Mar 2014 16:54:47 -0700
Message-ID: <8738i8eaig.fsf@servo.finestructure.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: list

--=-=-=
Content-Type: text/plain

On Sun, Mar 23 2014, Jani Nikula <jani@nikula.org> wrote:
> We really have very few configuration options, and so far none of them
> are such that we could make the decision for the user. I think in this
> case pushing the responsibility to the user would be just *us* being
> paranoid. What does that tell our users?
>
> I also think the user should consider doing backups before upgrading
> notmuch in the first place. I am generally more concerned about the user
> doing a database dump of the old database version using the new notmuch
> than doing the upgrade. (Although in this case I think we're fine unless
> the user decides 'notmuch dump folder:important' is enough.)

Sorry for the delay responding to this.

I really think the right way to handle a database upgrade is:

* fail notmuch new (with appropriate message) if run in quiet mode
* prompt user yes/no to upgrade database otherwise

This will allow all users to acknowledge the upgrade and do the
appropriate thing, regardless of configuration, without adding a new
config option.

jamie.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJTL3RHAAoJEO00zqvie6q8jjAP/i3572zTTmCNCNattzg5B9m3
AdeJPSFEEmLasQRVooqkigQpwiTGGGe8X2GaJpku+WXe9r9G4clW/CyNWFKOUQUJ
2zcAwaBNfIoDEM4B8xs/yDi8ZeCRugCdFhih1NdV3jmsSYcBS+iAwsMFtlNTuk6P
UYcWi8t75VLKTktTke0WHS6L+AYQFiT8fU86kLnyiUqcMCafycCpqlykPmiiSbaf
kkwzIVHJyRyiMn1+HL1+rOBbBX5Equ0P3Lpesqc6O2/73ouRxsUKCSeiosWQdFaB
uqE6le+/mhQQPB1SL4SPQjc2ZKOsidoMQ1l6o6UZS7wepzNKuaonIyzBG5RvF7VO
8UQAjBn7nE2jIFW/RmcxxOEQj8lEMax93MjNFJ5YBP7dVUO7BCOFiFo1BzyQF9qZ
C0o426s+YCTB5nKrSuP9l0uPVIrYh9P+ItWc5oiYp/S3kc8Ah6EioxqMe0LnTEwj
sf0s1nKDUudGo9dIGKeNSsi3DgzCObNViaK80WtIMI4xZCQyC00HQeZYo5nZSmFg
hf4kU13hy4/Sm9XmuhxD4v9Q0cazTNpGeQPHn5HZ3YSUUu1qYLAex4Rw3cgxjahL
3lAJPNfLsuy6nJrI5lP6e8+WtzC+0q+Ultb9v/7ntIuSwIXk7OuSULWDfjc7ynee
Kp26AARtkW4Mc8/ZDQDc
=ybEH
-----END PGP SIGNATURE-----
--=-=-=--