Return-Path: <jani@nikula.org>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 18815431FC3
	for <notmuch@notmuchmail.org>; Wed, 15 May 2013 09:31:51 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: -0.7
X-Spam-Level: 
X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
	tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id TyeiXLk6pxGZ for <notmuch@notmuchmail.org>;
	Wed, 15 May 2013 09:31:43 -0700 (PDT)
Received: from mail-lb0-f180.google.com (mail-lb0-f180.google.com
	[209.85.217.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id 9080F431FC2
	for <notmuch@notmuchmail.org>; Wed, 15 May 2013 09:31:43 -0700 (PDT)
Received: by mail-lb0-f180.google.com with SMTP id o10so2079686lbi.39
	for <notmuch@notmuchmail.org>; Wed, 15 May 2013 09:31:42 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=google.com; s=20120113;
	h=x-received:from:to:subject:in-reply-to:references:user-agent:date
	:message-id:mime-version:content-type:x-gm-message-state;
	bh=V2K55B1uyrnmeVudPVzALH8+FcPRE4iq+tpfzFkwqyM=;
	b=E0XLN4X6leFJYw2kOrToJATM20DKhhLckh0ahiUS8uvBjIceyzhQXX98vUMtJzOOni
	eexgLBTJiZQbTmWbAUpcL3jlk5dKVMV7xVAlM0AV5aI4O47Qm3e33V7/j+MYsQx5HOvL
	7CnN/uxqvVXYh5RVCbEOvle50UJwR5DEOi0sMMWnqK5Sb5V+svn1h501XyiasXqEDuX4
	AQ0mA0+NpXLQH4xSkz3rN6omP6xtdG3ESzlLCTVc8l5sJazBHw4JS4dHVKhYxR0A8A67
	ollrfWkTbP7nIrK3qrbPoG7FQhKviFmH0fO7hSy0RD3S7jCe/AYLwi8tJWfExVtaq7TJ
	WcPQ==
X-Received: by 10.112.155.132 with SMTP id vw4mr17756090lbb.87.1368635502078; 
	Wed, 15 May 2013 09:31:42 -0700 (PDT)
Received: from localhost (dsl-hkibrasgw2-58c376-211.dhcp.inet.fi.
	[88.195.118.211])
	by mx.google.com with ESMTPSA id z10sm1598555lbv.14.2013.05.15.09.31.39
	for <multiple recipients>
	(version=TLSv1.2 cipher=RC4-SHA bits=128/128);
	Wed, 15 May 2013 09:31:40 -0700 (PDT)
From: Jani Nikula <jani@nikula.org>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] build: fix out-of-tree builds
In-Reply-To: <87ehd8fdzg.fsf@zancas.localnet>
References: <1368615519-25977-1-git-send-email-jani@nikula.org>
	<87ehd8fdzg.fsf@zancas.localnet>
User-Agent: Notmuch/0.15.2+87~gc69f540 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Wed, 15 May 2013 19:31:37 +0300
Message-ID: <874ne49pcm.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain
X-Gm-Message-State:
 ALoCoQnf1iXg9bgdDPevnQi0KnUqD22EuJlxw083Ww9+PM30Q02tNsnkl4C10ZY6wMLFXFHGH8Wg
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 15 May 2013 16:31:51 -0000

On Wed, 15 May 2013, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>>  # List all subdirectories here. Each contains its own Makefile.local
>> -subdirs := compat completion emacs lib man parse-time-string
>> -subdirs += performance-test util test
>> +subdirs = compat completion emacs lib man parse-time-string performance-test util test
>
> Is this a functional change or a cosmetic one?

Functional. All of it seems to be required for out-of-tree builds (*) to
work. I'm afraid I've forgotten exactly why both := and += make it fail
(I wrote the patch a few months ago).

Jani.


(*) For example:

$ cd /some/empty/dir
$ /path/to/notmuch/configure
$ make