From: Jani Nikula <jani@nikula.org>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/4] lib: Only synchronize maildir flags for messages in
	maildirs
In-Reply-To: <1338742656-11640-4-git-send-email-amdragon@mit.edu>
References: <1338742656-11640-1-git-send-email-amdragon@mit.edu>
	<1338742656-11640-4-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.13+9~ga1668d0 (http://notmuchmail.org) Emacs/23.1.1
	(i686-pc-linux-gnu)
Date: Mon, 04 Jun 2012 07:01:57 +0000
Message-ID: <87pq9fr256.fsf@nikula.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list


The patch makes a lot of sense, and fixes the asymmetry introduced by
commit 95dd5fe5. I think it deserves a more verbose commit message,
along with that commit reference, and (eventually, not necessarily in
this series) a NEWS item of its own.

On Sun, 03 Jun 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> ---
>  lib/message.cc |    6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/lib/message.cc b/lib/message.cc
> index ed96477..bbac2ff 100644
> --- a/lib/message.cc
> +++ b/lib/message.cc
> @@ -1074,7 +1074,7 @@ notmuch_message_maildir_flags_to_tags (notmuch_message_t *message)
>      const char *flags;
>      notmuch_status_t status;
>      notmuch_filenames_t *filenames;
> -    const char *filename;
> +    const char *filename, *dir;
>      char *combined_flags = talloc_strdup (message, "");
>      unsigned i;
>      int seen_maildir_info = 0;
> @@ -1084,6 +1084,10 @@ notmuch_message_maildir_flags_to_tags (notmuch_message_t *message)
>  	 notmuch_filenames_move_to_next (filenames))
>      {
>  	filename = notmuch_filenames_get (filenames);
> +	dir = _filename_is_in_maildir (filename);
> +
> +	if (! dir)
> +	    continue;
>  
>  	flags = strstr (filename, ":2,");
>  	if (! flags)
> -- 
> 1.7.10
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch