To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
References: <1259124875-28212-1-git-send-email-bart@jukie.net>
	<1259124875-28212-2-git-send-email-bart@jukie.net>
	<1259124875-28212-3-git-send-email-bart@jukie.net>
	<87iqcvbgaw.fsf@yoom.home.cworth.org>
From: Bart Trojanowski <bart@jukie.net>
In-Reply-To: <87iqcvbgaw.fsf@yoom.home.cworth.org>
Message-Id: <20091128022115.662B62053465E@oxygen.jukie.net>
Date: Fri, 27 Nov 2009 21:21:15 -0500 (EST)
Subject: Re: [notmuch] [PATCH 2/3] have _notmuch_thread_create mark which
	messages matched the query
Precedence: list

On Fri, 27 Nov 2009 17:15:35 -0800, Carl Worth <cworth@cworth.org> wrote:
> This is a very useful feature, Bart. Thanks for coding it up. And it's a
> nicely-implemented patch series as well.

Thanks.  I've found it very handy.

> By the way, do you think that this support obviates the
> --only-matching-messages option for "notmuch search" or does anyone
> still want that?

I personally don't have much use for it (in the notmuch.vim UI).  However, I
can see it being useful if someone reads the messages on the terminal, maybe
using some less verbose output format.

> Or maybe the right fix is to make "notmuch show" display only matching
> messages by default, (which will likely be more friendly to a user
> manually typing "notmuch show" at the command line). And then make the
> user-interfaces pass an "--entire-thread" option (or so) to get the
> current results.

Sure, I'll fix up the patch and submit it in a bit.

> If we're going to make the command-line user-interface usable on its
> own, then I definitely want to make it be the user interfaces that have
> to pass extra-long command-line options to get what they want.

Agreed.  I still think we could use some templating for the different output
modes.  Maybe it will be important enough for soemone to implement :)

> One quick point on naming:
> 
> >  /* Message flags */
> >  typedef enum _notmuch_message_flag {
> > +    NOTMUCH_MSG_FLAG_MATCHING_SEARCH,
> >  } notmuch_message_flag_t;
> 
> I like my enum values to match their type name without abbreviation. I
> also like internals (like this enum value) to match the way they are
> exposed in the interface, (which in this case is "match"). So I'd like
> the above value to instead be:
> 
> 	NOTMUCH_MESSAGE_FLAG_MATCH

OK.  Patch is in flight.

Cheers,
-Bart

-- 
email sent from notmuch.vim plugin