Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id EAB68429E3B for ; Tue, 17 Jan 2012 01:05:29 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LVECzqAwR6CZ for ; Tue, 17 Jan 2012 01:05:29 -0800 (PST) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 4FC47429E2F for ; Tue, 17 Jan 2012 01:05:29 -0800 (PST) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1Rn4yr-0006zD-3l; Tue, 17 Jan 2012 09:05:25 +0000 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1Rn4yq-0003Vg-SG; Tue, 17 Jan 2012 09:05:24 +0000 From: Mark Walters To: Austin Clements Subject: Re: [PATCH 1/1] Make buttons for attachments allow viewing as well as saving In-Reply-To: <20120117022330.GE16740@mit.edu> References: <1326629796-11436-1-git-send-email-markwalters1009@gmail.com> <1326629796-11436-2-git-send-email-markwalters1009@gmail.com> <87wr8r5trv.fsf@servo.finestructure.net> <87lip7fhkc.fsf@qmul.ac.uk> <20120117022330.GE16740@mit.edu> User-Agent: Notmuch/0.11~rc2+73~g1ea2b60 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu) Date: Tue, 17 Jan 2012 09:06:11 +0000 Message-ID: <8739beitq4.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 94.192.233.223 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: c28cfe8cf3b196100d0309f2d0490ee4 (of first 20000 bytes) X-SpamAssassin-Score: -1.7 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.7 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay * domain * 0.6 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2012 09:05:30 -0000 > > I wonder if the "problem" comes from me doing things in a non-lispy > > fashion (I am completely new to lisp). Thus > > notmuch-show-part-button-default-action is a variable that gets passed > > around rather than a function. > > Sorry, I should have looked at the bigger context in this patch. I > think Jameson was implying that notmuch-show-part-button-default > should change to > > (defun notmuch-show-part-button-default (&optional button) > (interactive) > (funcall notmuch-show-part-button-default-action button)) > > I would go one step further and say that each action should probably > be a separate function. That is, break notmuch-show-part-action into > separate functions and simply invoke the appropriate function, rather > than performing a fixed data dispatch. This would be more flexible > and Lispy. It may be that your approach works out better, but I'd at > least give this a shot. I am happy to make that change. My original patch in the summer was more like that: id:"CALUdzSWAto+4mCUOOMk+8vFs+Pog-xUma6u-Aqx2M6-sbyQROg@mail.gmail.com" Is that more what you had in mind? (Only in broad terms: Obviously I would need to add in the customization and default function etc). I decided that I didn't like the code duplication (but I am completely new to lisp) which is why I changed it for this submission. Best wishes Mark