Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A7409429E30 for ; Wed, 25 May 2011 15:34:07 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ajx-0UBKznqE for ; Wed, 25 May 2011 15:34:06 -0700 (PDT) Received: from mail-fx0-f53.google.com (mail-fx0-f53.google.com [209.85.161.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 8DC28431FB6 for ; Wed, 25 May 2011 15:34:06 -0700 (PDT) Received: by fxm8 with SMTP id 8so236335fxm.26 for ; Wed, 25 May 2011 15:34:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:from:to:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type; bh=mdluss1YOqCOdrrUcjBOcjmHnft5kpl4NF1P6fbDFYo=; b=AtXAJGKlYb9ziQsbgpsurU3ENh418I9GEScEXcN59noR7vIYBbvX3QcpPDAuWqFFbC 80pahwVeDsnR8E6D3SSQYx36ZIFWrw1bJBj6j4YrrM+Y2OTXVtCaDBYpJV+zeHHVTyWj l/CpsJkm3CqNjMyGopq3o4kEgraIxfEzTU7Tk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; b=dDdgxlkGgVL/CZliYN2Xp8xjn6E8NiDhtJ+yJv1F+ZrzcVXivrUtlS2fLrjM9oP1Fx dIqD/WOkgrxiT8OCYVaHHwpKYRJXDP2WF+WMCyLlU5lmBJd1n2q0e+DfDPsMh5dnosGr IGJnt3j/aV72YZ6DeT7zuZz8Kts3QgF2k2Ppo= Received: by 10.223.24.134 with SMTP id v6mr111538fab.146.1306362845348; Wed, 25 May 2011 15:34:05 -0700 (PDT) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id g7sm39158fac.39.2011.05.25.15.34.04 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2011 15:34:04 -0700 (PDT) From: Dmitry Kurochkin To: Carl Worth , notmuch@notmuchmail.org Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view. In-Reply-To: <87oc2qa07g.fsf@yoom.home.cworth.org> References: <1306361416-5019-1-git-send-email-dmitry.kurochkin@gmail.com> <1306361416-5019-4-git-send-email-dmitry.kurochkin@gmail.com> <87oc2qa07g.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.5-216-g0104e23 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Thu, 26 May 2011 02:34:28 +0400 Message-ID: <87k4depfyj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2011 22:34:07 -0000 On Wed, 25 May 2011 15:23:47 -0700, Carl Worth wrote: > On Thu, 26 May 2011 02:10:14 +0400, Dmitry Kurochkin wrote: > > Before the change, message and citation invisibility overlays > > conflicted: if some citation is made visible and then the whole > > message is hidden, that citation remained visible. > > That sounds like quite a bug. I'd love to see this series also add a > test case for that. > I am not sure how it is best to test this. The common `printc' method for emacs tests does not work, because it prints invisible parts as well. We need either to find a way to print only visible text on the console, or test it inside emacs somehow. Any suggestions? Note that this is exactly the patch that hits the isearch emacs bug. Do I understand correctly that you are ready to push the series despite of it (given that we have a test)? Regards, Dmitry > -Carl > > -- > carl.d.worth@intel.com Non-text part: application/pgp-signature