From: Thomas Jost <schnouki@schnouki.net>
To: Austin Clements <amdragon@mit.edu>
Subject: Re: [PATCH] emacs: Let the user choose where to compose new mails
In-Reply-To:
 <CAH-f9WvuSFJJC+e0JRFwKD8xYtyncNYZreCXxxMDeSahpWAuRw@mail.gmail.com>
References: <87pqhlh64c.fsf@thor.loria.fr>
	<1319528464-22654-1-git-send-email-schnouki@schnouki.net>
	<CAH-f9WvuSFJJC+e0JRFwKD8xYtyncNYZreCXxxMDeSahpWAuRw@mail.gmail.com>
User-Agent: Notmuch/0.9+66~g79e6e2e (http://notmuchmail.org) Emacs/24.0.90.1
	(x86_64-unknown-linux-gnu)
Date: Wed, 09 Nov 2011 19:50:55 +0100
Message-ID: <87ipmt8700.fsf@schnouki.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch@notmuchmail.org
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Fri, 4 Nov 2011 23:51:55 -0400, Austin Clements <amdragon@mit.edu> wrote:
> This seems like a good option to have, but your approach seems
> unnecessarily complicated. I'm always wary of defcustom's :set because
> it means you can't just setq the variable, which defeats the
> underlying beauty of the customize system.

Actually I use it with setq without any problem. But yes, it's too
complicated...

> You could eliminate the other two variables and compute them on the
> fly, or, if you really feel they may need to be controlled
> independently, make the custom variable a pair or alist (which you can
> hide behind a few const choices).

Computing them on the fly is probably cleaner. But I'm not sure if the
switch-function and dedicated flag must be independent or not. From what
I've tested it's *much* more pleasant to use with the dedicated flag,
but I don't know how other people feel about this...

> Alternatively, it seems like the variable could instead
> take a single function (basically what notmuch-mua-switch-function is
> now) and you could provide two new functions that simply combine
> switch-to-buffer-other-x and set-window-dedicated-p.

I've tried that, but for some reason it doesn't work when forwarding a
message: the dedicated flag is reset somewhere inside message-forward,
but I don't know where nor why. (I haven't investigated much though.)

> The defcustom would be more user-friendly if it gave a choice between
> const values, rather than requiring the user to enter a symbol value
> (and then possibly rejecting it on validation).  Something like
>   :type '(choice (const :tag "Compose in the current window" current-wind=
ow)
>                  (const :tag "Compose mail in a new window"  new-window)
>                  (const :tag "Compose mail in a new frame"   new-frame))

Yep, that's much better. I'll try to rewrite this patch using this and
on-the-fly computations of the switch-function and dedicated flag.

Thank you for the review!

Regards,

=2D-=20
Thomas/Schnouki

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQEcBAEBAgAGBQJOusuPAAoJEMPdciX+bh5Ib1AH/0xzI3WK64F9CxZ/gucsFPgp
hmIDbEIavRe2fxcv74PiTtRvA/QgQU490jp2zMo+EySlMulRNgoONMZYS+dd/6Fz
1Uz3lzqtXLLvHQI/1FKQdQLo+VoBMtsP7IetYlO5pFzoQElrCTe6ST/CIgvqsqkW
4Pg5BMon8ZjzNht2SLIizrUVCRFnB6VU0YrLfYDQt0Xigbok+3reUJoVLl8UNl1w
m2Ug+eyx9DiGfE4zVackd27EQdRQgwLavw92eqmJYS06EhrP71CheTFEJy++3Vxo
6ko8XzGWJsYPUDBQrDHzDQdRcMmCo15kJD+NQmG5/rRvmGScBiXHqsF+7XleZBU=
=RQQA
-----END PGP SIGNATURE-----
--=-=-=--