From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [Patch v8 4/6] Update devel/schemata for --entire-thread=false
In-Reply-To: <1339842107-10632-5-git-send-email-markwalters1009@gmail.com>
References: <1339842107-10632-1-git-send-email-markwalters1009@gmail.com>
	<1339842107-10632-5-git-send-email-markwalters1009@gmail.com>
User-Agent: Notmuch/0.12+132~gf2f390b (http://notmuchmail.org) Emacs/23.3.1
	(i486-pc-linux-gnu)
Date: Sat, 23 Jun 2012 11:20:42 -0400
Message-ID: <87sjdm12d1.fsf@awakening.csail.mit.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Sat, 16 Jun 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> Also remove the Json --entire-thread item from devel/TODO.
> ---
>  devel/TODO     |    2 --
>  devel/schemata |    2 +-
>  2 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/devel/TODO b/devel/TODO
> index 7b750af..eb757af 100644
> --- a/devel/TODO
> +++ b/devel/TODO
> @@ -92,8 +92,6 @@ and email address in the From: line. We could also then easily support
>  "notmuch compose --from <something>" to support getting at alternate
>  email addresses.
>  
> -Fix the --format=json option to not imply --entire-thread.
> -
>  Implement "notmuch search --exclude-threads=<search-terms>" to allow
>  for excluding muted threads, (and any other negative, thread-based
>  filtering that the user wants to do).
> diff --git a/devel/schemata b/devel/schemata
> index 977cea7..8fcab8e 100644
> --- a/devel/schemata
> +++ b/devel/schemata
> @@ -32,7 +32,7 @@ thread = [thread_node*]
>  
>  # A message and its replies (show_messages)
>  thread_node = [
> -    message?,                 # present if --entire-thread or matched
> +    message?,                 # null if not matched and not --entire-thread

To keep with the syntax of the rest of this file, this should be
    message|null,

If this is the only thing to change in this series, maybe it should just
be a follow-up patch.

>      [thread_node*]            # children of message
>  ]
>  
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch