From: Michal Sojka <sojkam1@fel.cvut.cz>
To: Jameson Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/4] Import date/time parser from GNU coreutils
In-Reply-To: <87ei82uh8h.fsf@servo.finestructure.net>
References: <1295783247-21900-1-git-send-email-sojkam1@fel.cvut.cz>
	<1295783247-21900-2-git-send-email-sojkam1@fel.cvut.cz>
	<87ei82uh8h.fsf@servo.finestructure.net>
User-Agent: Notmuch/0.5-87-g9705d00 (http://notmuchmail.org) Emacs/23.2.1
	(x86_64-pc-linux-gnu)
Date: Tue, 25 Jan 2011 09:41:42 +0100
Message-ID: <87r5c1iddl.fsf@steelpick.2x.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Precedence: list

On Mon, 24 Jan 2011, Jameson Rollins wrote:
> On Sun, 23 Jan 2011 12:47:24 +0100, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
> > This function have quite a lot dependencies. We may reduce them later it
> > it is a problem.
> > ---
> >  lib/c-ctype.c  |  398 +++++++
> >  lib/c-ctype.h  |  297 +++++
> >  lib/getdate.c  | 3497 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  lib/getdate.h  |   22 +
> >  lib/getdate.y  | 1572 +++++++++++++++++++++++++
> >  lib/gettime.c  |   48 +
> >  lib/intprops.h |   83 ++
> >  lib/timespec.h |   39 +
> >  lib/verify.h   |  140 +++
> >  9 files changed, 6096 insertions(+), 0 deletions(-)
> >  create mode 100644 lib/c-ctype.c
> >  create mode 100644 lib/c-ctype.h
> >  create mode 100644 lib/getdate.c
> >  create mode 100644 lib/getdate.h
> >  create mode 100644 lib/getdate.y
> >  create mode 100644 lib/gettime.c
> >  create mode 100644 lib/gettime.h
> >  create mode 100644 lib/intprops.h
> >  create mode 100644 lib/timespec.h
> >  create mode 100644 lib/verify.h
> 
> Hi, Michal.  I don't fully understand what's going on here, but it seems
> like you're embedding code copies from somewhere else.  If that's the
> case, is there a reason that we would need to do that, rather than just
> linking against an external library?

Well, if the embedded code is available in a library, it would be
definitely better to just use the library. But the above code is
statically linked to things like `date` command and is not available
separately.

Most of the dependencies could be eliminated since they usually
replicate functionality which is available in modern C library and are
there only for compatibility reasons.

On the other hand, if anybody knows a better date parser, perhaps in a
separate library, let me know.

-Michal