Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 5ECA2431FB6 for ; Tue, 1 Oct 2013 01:50:35 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1vjzhPFws1IK for ; Tue, 1 Oct 2013 01:50:29 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by olra.theworths.org (Postfix) with ESMTP id 24996431FAE for ; Tue, 1 Oct 2013 01:50:29 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id B7D73100033; Tue, 1 Oct 2013 11:50:22 +0300 (EEST) From: Tomi Ollila To: Mark Walters , notmuch@notmuchmail.org Subject: Re: [PATCH 0/2] Move pick to use prefix-arg rather than Escape In-Reply-To: <1379965979-14752-1-git-send-email-markwalters1009@gmail.com> References: <1379965979-14752-1-git-send-email-markwalters1009@gmail.com> User-Agent: Notmuch/0.16+87~g451fefe (http://notmuchmail.org) Emacs/24.3.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Oct 2013 08:50:35 -0000 On Mon, Sep 23 2013, Mark Walters wrote: > To try and minimise the impact of pick on the code base some > keybindings which would naturally use a prefix argument were done as a > separate keybinding with "M-". (The reason is that a prefix argument > would have meant modifying the original function whereas the M- could > be bound to a new function in pick) > > The first patch is actually all inside pick anyway so can be > changed. The second patch removes a different occurence of the M- > keybinding temporarily: we can add back the prefix-arg version once > pick is in mainline. > > I also have some patches to add the prefix-argument (going to pick) to > hello buttons and other search entry points. (I think this is a good > reason to make the change from M- to prefix-arg as it is much easier > to link the prefix-arg into button actions). LGTM. Tomi > > Best wishes > > Mark > > Mark Walters (2): > contrib: pick: move M-RET to prefix-arg RET > contrib: pick: remove temporary keybinding > > contrib/notmuch-pick/notmuch-pick.el | 52 +++++++++++++--------------------- > 1 files changed, 20 insertions(+), 32 deletions(-) > > -- > 1.7.9.1 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch