Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C1CC7431FD0 for ; Wed, 7 Dec 2011 14:13:23 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xCszLM+H0CSN for ; Wed, 7 Dec 2011 14:13:19 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id C9936431FB6 for ; Wed, 7 Dec 2011 14:13:19 -0800 (PST) Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) by earth-doxen-postvirus (Postfix) with ESMTP id E468466E00EA; Wed, 7 Dec 2011 14:13:18 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new Received: from finestructure.net (m62.ligo.caltech.edu [131.215.115.162]) (Authenticated sender: jrollins) by earth-doxen-submit (Postfix) with ESMTP id 2959066E0089; Wed, 7 Dec 2011 14:13:16 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id B892B598; Wed, 7 Dec 2011 17:13:15 -0500 (EST) From: Jameson Graef Rollins To: Jani Nikula , notmuch@notmuchmail.org Subject: Re: [PATCH v3 0/2] notmuch hooks In-Reply-To: <87iplsb23a.fsf@nikula.org> References: <7fbe6befcf31881a9bca672f55b93501249a220c.1322859389.git.jani@nikula.org> <87hb1dru9c.fsf@servo.finestructure.net> <87iplsb23a.fsf@nikula.org> User-Agent: Notmuch/0.10.2+73~g6bbc3f1 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Wed, 07 Dec 2011 14:13:13 -0800 Message-ID: <87ipls81za.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2011 22:13:23 -0000 --=-=-= On Wed, 07 Dec 2011 21:42:33 +0200, Jani Nikula wrote: > I wonder, though, whether the samples should be created only when > creating the database, or whenever the hooks directory does not exist? > The latter, I guess. Otherwise existing notmuch users would hardly get > the sample hooks. I agree, the later would be better. notmuch new should just create the hooks directory (and example scripts) if they don't already exist. I also think it's nice to have the scripts not executable to begin with, and the hook runner only executes the script if they are executable. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJO3+T5AAoJEO00zqvie6q8c4AP/RM7KZsgqm8U7LmnrMR50wfU jsKJvmHL1CAJs4B5Do9z8xZHopzeC11Ik8g5XeOHmvYmn1L7oydyosXgAoCIoi0Y csRbCx6VECg9lhdRmWlgJB+UFN/VLXQ68JXZtMcEyWE59MZwVKUyWcVW0TPVUSec KAI/vxBqp3U455WPaIME3r6o9pZRWZe8Ttpe0zKnP2IaMtgZcFCfmC6Xm6VOe7ZM Os6dKD3bveuC9877oxxaAt4wwOtTBUSRfoSOlA7FA+il1x+3t96FnwSKzytXC0ey LvAxihpBuwV6HQ847UDfryXeV5jCltVgc4X4zbGFFrNPwrnmNzOd/BGLjAqrwwGe vn6Ck+Fz1ckne/as5mbxBqR65iYeHJPvqHtZKST/lKKBwJ8d+vIIi56tN/QYT8ll GOoNUWcOflCcZQkZApcesaAOEslbcuMI30xuMBhqQAa9rHvUl4/u94bIYDrss8xw btty8qG7UrKlfuZax6OfZOE5qm8eSvFizjCmNW53EqkiZqhqcM4fm79pQ6Zjl4cJ 6quuwlOnbArlZWwLJBU0MqjzDn29KMw5ttnRnd1fwhUmxzThNA8ufEZ8Yst2/rmB Cg623LJWho/NK5V8eiPBgsKcCS9qisGw0FceoOFSFGv4ExPjyy/FyVFnUjyY+aeZ GtyBPhTkF5UBllWprXsK =6nfP -----END PGP SIGNATURE----- --=-=-=--