To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
Subject: Re: [PATCH 2/3] test: Add `test_emacs_expect_t'.
In-Reply-To: <87zkdmwfi7.fsf@gmail.com>
References: <87pqei327k.fsf@gmail.com>
	<1326809224-22673-1-git-send-email-dme@dme.org>
	<1326809224-22673-2-git-send-email-dme@dme.org>
	<87zkdmwfi7.fsf@gmail.com>
User-Agent: Notmuch/0.11+64~g42e8f66 (http://notmuchmail.org) Emacs/24.0.92.1
	(x86_64-pc-linux-gnu)
From: David Edmondson <dme@dme.org>
Date: Tue, 17 Jan 2012 15:09:22 +0000
Message-ID: <cund3aipdr1.fsf@hotblack-desiato.hh.sledj.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha1; protocol="application/pgp-signature"
Cc: notmuch <notmuch@notmuchmail.org>
Precedence: list

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

On Tue, 17 Jan 2012 18:49:36 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
l.com> wrote:
> > +		# We cannot call 'test_emacs' in a subshell, because
> > +		# the setting of EMACS_SERVER would not persist
> > +		# throughout a sequence of tests, so we use a
> > +		# temporary file.
> > +		tmp=3D"$TMPDIR"; if [ -z "$tmp" ]; then tmp=3D/tmp; fi
> > +		output=3D"$tmp/test_emacs_output.$$"
> > +		test_emacs "$1" > "${output}"
> > +		result=3D$(cat "${output}")
> > +		rm -f "${output}"
>=20
> I wonder if there is any bash trick which can help here?

I'm not aware of one, but I'm not a bash expert.

> Another option is to start emacs server before using test_emacs in
> subshell.  See emacs-subject-to-filename for an example.  I think this
> is a better option than using a temporary file.

I think that's a very poor option. Forcing knowledge the breakage into
all of the users may make applying any future fix more difficult.

--=-=-=
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk8VjyIACgkQaezQq/BJZRYEmwCfVwugFLMuHzeTU5bw5akCksnX
na0AnRzlkYL2sYbSzKg7osfP8/R7FAw6
=N5/B
-----END PGP SIGNATURE-----
--=-=-=--