Return-Path: <tomi.ollila@iki.fi>
X-Original-To: notmuch@notmuchmail.org
Delivered-To: notmuch@notmuchmail.org
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 489B76DE014D
 for <notmuch@notmuchmail.org>; Mon, 27 Jun 2016 08:05:23 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.567
X-Spam-Level: 
X-Spam-Status: No, score=0.567 tagged_above=-999 required=5 tests=[AWL=-0.085,
  SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id jKOa9hPKjCZY for <notmuch@notmuchmail.org>;
 Mon, 27 Jun 2016 08:05:14 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 8ECE56DE00CC
 for <notmuch@notmuchmail.org>; Mon, 27 Jun 2016 08:05:13 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id C06851000E1;
 Mon, 27 Jun 2016 18:04:31 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2] test: add "set -u" to test-lib.sh
In-Reply-To: <87a8i64u8o.fsf@maritornes.cs.unb.ca>
References: <1465336777-31225-1-git-send-email-tomi.ollila@iki.fi>
 <87a8i64u8o.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.22+54~gf8fd4ff (https://notmuchmail.org) Emacs/24.5.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Mon, 27 Jun 2016 18:04:31 +0300
Message-ID: <m21t3i7jwg.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jun 2016 15:05:23 -0000

On Mon, Jun 27 2016, David Bremner <david@tethera.net> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> This prohibits unset variables to expand to empty strings.
>> Without this e.g misspelled variables cause unintentional results.
>>
>> Now all the test variables are either initialized, or in case of
>> optional arguments and user-provided environment variables (i.e.
>> when it is not know whethet the variable is set) the form
>> ${variable-} is used.
>>
>> Two unusable lines (leftovers?) in T360-symbol-hiding.sh were removed;
>> this was the only non-lib test code that needed to be edited for this
>> change to work.
>
> Hi Tomi;
>
> I like the idea, but currently I get many test failures with
>
> /test-lib.sh: line 926: test_subtest_missing_external_prereq_: unbound
> variable

Interesting... have to investigate why I did not get those (IMO I should have...)

Tomi

>
> d