Return-Path: X-Original-To: notmuch@notmuchmail.org Delivered-To: notmuch@notmuchmail.org Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E0021431FC7 for ; Sat, 28 Jan 2012 09:14:50 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TNjlgnBRr9o3 for ; Sat, 28 Jan 2012 09:14:50 -0800 (PST) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 40C1D431FC3 for ; Sat, 28 Jan 2012 09:14:50 -0800 (PST) Received: from zancas.localnet (fctnnbsc36w-156034071197.pppoe-dynamic.High-Speed.nb.bellaliant.net [156.34.71.197]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id q0SHEjnf011403 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Sat, 28 Jan 2012 13:14:45 -0400 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1RrBrR-0007pQ-7A; Sat, 28 Jan 2012 13:14:45 -0400 From: David Bremner To: Jani Nikula Subject: Re: [PATCH] emacs: globally replace non-branching "(if COND (progn ..." with "(when ..." In-Reply-To: References: <87k44uprvy.fsf@praet.org> <1326532638-22068-1-git-send-email-pieter@praet.org> <87y5ssxam7.fsf@zancas.localnet> User-Agent: Notmuch/0.11+130~g480a83e (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 28 Jan 2012 13:14:45 -0400 Message-ID: <87ty3fycje.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Notmuch Mail X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2012 17:14:51 -0000 On Sat, 28 Jan 2012 14:55:22 +0200, Jani Nikula wrote: > On Jan 28, 2012 2:41 PM, "David Bremner" wrote: > > Sometimes someone (Dmitry?) sent patches that separated a small functional > change, and the big non-functional indentation change it caused, > separately. Would you prefer (or tolerate ;) that style? Hmm, that might be nicer, I'm not 100% sure. I wouldn't say it's mandatory for a patch like this (and I'd say other peoples views on what's easy to review are at least as important as mine here). d